Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[Feature] Clean up filterbar appearance in transitional styles #227

Closed
7 tasks
zackkrida opened this issue Sep 15, 2021 · 5 comments · Fixed by #236
Closed
7 tasks

[Feature] Clean up filterbar appearance in transitional styles #227

zackkrida opened this issue Sep 15, 2021 · 5 comments · Fixed by #236
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon
Projects

Comments

@zackkrida
Copy link
Member

zackkrida commented Sep 15, 2021

The current filterbar is particularly unpleasant with odd font sizes. As this is such a commonly-used feature, we should clean it up a bit to better reflect the mockup.

Mockup

image

Current appearance

CleanShot 2021-09-15 at 19 21 11@2x

Tasks

Sizes

CleanShot 2021-09-15 at 19 04 46@2x

CleanShot 2021-09-15 at 19 04 39@2x

Additionally, the filter headings should be:

font-size: 1rem;
font-weight: 600;
@zackkrida zackkrida added good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Sep 15, 2021
@dhruvkb dhruvkb added this to Backlog in Openverse Sep 15, 2021
@DillonKyleDev
Copy link
Contributor

Hi!
I'm new to contributing to open source and want to help. Forgive the silly question but how do I find the specific scss file for the filter bar?
Thank you!

@zackkrida
Copy link
Member Author

zackkrida commented Sep 16, 2021

Hi @DillonKyleDev, and welcome! 🎉 I think you'll have to use a bit of trial and error. The Filter sidebar uses some global styles as well as styles within the component.

This is the main Vue file for the filters, and might be a good place for you to start exploring:

https://github.com/WordPress/openverse-frontend/blob/db693f08f2046c24808addf9f2636352d010e062/src/components/Filters/FiltersList.vue

Also, if you do not have the project running locally, this would be a great thing to read: https://github.com/WordPress/openverse-frontend#local-development

@DillonKyleDev
Copy link
Contributor

@zackkrida you are so right, I'll figure it out! Thanks for the nudge in the right direction :)

@zackkrida
Copy link
Member Author

zackkrida commented Sep 16, 2021

@DillonKyleDev have fun 😄 If you need help, we also have a slack channel that you'll be able to view after signing up here where other contributors can help you out!

@DillonKyleDev
Copy link
Contributor

Good morning!
I was wondering if you could somehow give me access to the figma links that are posted in both this issue and in the issue linked in task number 7? For some reason I'm not able to view either of them, but I'm not familiar with figma.

Also I was curious about the task:

New sidebar icon (use SVGs please)

Which icon needs replacing?

Thanks for your patience!

@dhruvkb dhruvkb moved this from Backlog to In progress in Openverse Sep 17, 2021
Openverse automation moved this from In progress to Done! Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging a pull request may close this issue.

2 participants