Unit tests: Move classes out of includes/functions.php into their own file

[Frank Klein]

The includes/functions.php file includes two classes, Basic_Object and Basic_Subclass. The attached patch moves these functions into their own file, and includes them in tests/basic.php.

[boonebgorges]

@Frank Klein Thanks for the patch!

[boonebgorges]

In 38285:

Tests: Move some utility classes to their own files.

Props Frank Klein.
Fixes #37523.

[TimothyBlynJacobs]

This broke unit tests that I have that use the Basic_Object class in a test since they are now only loaded in that test file instead of the functions file. Could the require calls be moved to the functions file so those classes are always available?

[boonebgorges]

Replying to TimothyBlynJacobs:

This broke unit tests that I have that use the Basic_Object class in a test since they are now only loaded in that test file instead of the functions file. Could the require calls be moved to the functions file so those classes are always available?

Yes.

[DylanAuty]

Revised Patch based on suggestions/solutions offered.

[Frank Klein]

I think it would be cleaner to load the files during the bootstrap process, instead of including them in functions.php. Nothing in this file relies on the two classes, but the tests do.

There's a small typo in the patch. It's in the word UnitTests in the documentation header of class-basic-object.php.

[DylanAuty]

New Revision of the previous patch file I submitted. With the changes suggested by @Frank Klein. I moved the including of the classes to the bootstrap.php file instead. Below the inclusion of the funtions.php file as no reference is made to the classes up to this point. Did not test this, however it seems like the revision would run as expected

[DylanAuty]

Replying to Frank Klein:

I think it would be cleaner to load the files during the bootstrap process, instead of including them in functions.php. Nothing in this file relies on the two classes, but the tests do.

There's a small typo in the patch. It's in the word UnitTests in the documentation header of class-basic-object.php.

Thanks for pointing that out. I have revised my patch and submitted it.

Apologies for the typo on that one.

[boonebgorges]

Thanks for the patches. I'm inclined to leave the require_once statements in functions.php, given that:

• our main goal is backward compatibility, and functions.php is where the classes were previously loaded in the call graph
• none of this will matter once we autoload classes; see #36335

[boonebgorges]

In 38444:

Tests: Add docblocks for Basic_Object and Basic_Subclass classes.

Props DylanAuty.
See #37523.

[boonebgorges]

In 38445:

Tests: Require Basic_Object and Basic_Subclass files earlier in call stack.

This ensures compatibility with third-party tools using these classes
in their test suites, after [38285].

Props DylanAuty, Frank Klein, TimothyBlynJacobs.
Fixes #37523.