Remove dead / unreachable code in core/calendar block renderer.
#14546
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvanhal
requested review from
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
Soean,
talldan and
youknowriad
as code owners
|
@jorgefilipecosta - what was the reason these global variables had to be updated? If it is still necessary, they should be assigned back to the initial value before the |
jorgefilipecosta
reviewed
Mar 21, 2019
jorgefilipecosta
approved these changes
Mar 21, 2019
The change looks good to me
Thank you for submitting this fix!
mkevins
added a commit
to mkevins/gutenberg
that referenced
this issue
Mar 26, 2019
…rdPress#14546) ## Description The `core/calendar` block registration file contains variable assignments after a `return` statement (hence dead code). After removing this code, I discovered that the variables in question (`$previous_monthnum` and `$previous_year`) are never used anyway (not in this function, not in `get_calendar` and never in the entire codebase for that matter). This PR removes dead code and unused variables to prevent any future ambiguities or bugs. ## How has this been tested? Tests pass, not sure how to test server side rendering well This change seems safe / harmless, however ## Types of changes Refactor, non-breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description
The
core/calendarblock registration file contains variable assignments after areturnstatement (hence dead code). After removing this code, I discovered that the variables in question ($previous_monthnumand$previous_year) are never used anyway (not in this function, not inget_calendarand never in the entire codebase for that matter).This PR removes dead code and unused variables to prevent any future ambiguities or bugs.
How has this been tested?
Tests pass, not sure how to test server side rendering well
This change seems safe / harmless, however
Types of changes
Refactor, non-breaking
The text was updated successfully, but these errors were encountered: