Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RN Native] Fix Video block crash on drawing on Android #15857

Merged
merged 2 commits into from May 29, 2019
Merged

[RN Native] Fix Video block crash on drawing on Android #15857

merged 2 commits into from May 29, 2019

Conversation

daniloercoli
Copy link
Contributor

@daniloercoli daniloercoli commented May 28, 2019 •
edited

This PR does fix a crash that happens on Android when the video file upload finishes and the block tries to render the preview. Details are here: wordpress-mobile/WordPress-Android#9943

Companion PR for GB-mobile: wordpress-mobile/gutenberg-mobile#1039

To test Android

  • Start the wp-android app
  • Add a video block to the editor and upload a video
  • Wait until the upload ends
  • The preview should be on the screen
  • No crash should happen
  • The bg color of the block is light grey

To test on iOS

  • Start the wp-iOS app
  • Add a video block to the editor and upload a video
  • Wait until the upload ends
  • The preview should be on the screen
  • No crash should happen
  • The bg color of the block is black

@daniloercoli daniloercoli added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label May 28, 2019
@daniloercoli daniloercoli mentioned this pull request May 28, 2019
Closed
@daniloercoli
Merge branch 'master' of https://github.com/WordPress/gutenberg into …
de41bb7 
…rnmobile/fix-video-block-crash-on-draw-android

* 'master' of https://github.com/WordPress/gutenberg:
  Disable video, quote blocks but for development (#15856)
@daniloercoli daniloercoli mentioned this pull request May 29, 2019
Merged
mkevins
mkevins approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on Android (via WordPress-Android), and it does prevent the crash as described. LGTM! 🎉

@daniloercoli daniloercoli merged commit 95e73d9 into master May 29, 2019
@daniloercoli daniloercoli deleted the rnmobile/fix-video-block-crash-on-draw-android branch May 29, 2019 13:54
@marecar3 marecar3 mentioned this pull request Jun 4, 2019
Merged
@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019
sbardian pushed a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019
@daniloercoli @sbardian
Do not set the background color for Android (WordPress#15857)
f45edd6
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
@daniloercoli
Do not set the background color for Android (WordPress#15857)
83bb783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

@hypest hypest Awaiting requested review from hypest

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 5.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daniloercoli @mkevins @youknowriad