Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end 2 end test heading color #15784

Merged
merged 1 commit into from May 30, 2019
Merged

Conversation

jorgefilipecosta
Copy link
Member

Description

This PR just adds a simple end 2 end test to the colors mechanism. It is the first time this mechanism is covered in a test so I guess it is a valuable addition.

How has this been tested?

I verified the end 2 end tests execute with success.

@nerrad nerrad added [Package] E2E Test Utils /packages/e2e-test-utils [Type] Enhancement A suggestion for improvement. labels May 25, 2019
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@talldan talldan merged commit 3f987b5 into master May 30, 2019
@talldan talldan deleted the add/end-2-end-test-heading-colors branch May 30, 2019 09:44
@youknowriad youknowriad added this to the Gutenberg 5.9 milestone Jun 7, 2019
sbardian pushed a commit to sbardian/gutenberg that referenced this pull request Jul 29, 2019
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] E2E Test Utils /packages/e2e-test-utils [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants