Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/18066 add plugin area to widgets screen #25074

Conversation

@ryanwelcher
Copy link
Contributor

@ryanwelcher ryanwelcher commented Sep 4, 2020

Description

This PR adds the PluginArea to the WidgetAreasBlockEditorProvider component and replaces #18067.

This is the first step for #18068

Closes #18066

How has this been tested?

Tested locally to ensure no visual changes occur.

Screenshots

Types of changes

Introduces the <PluginArea/> component. No visual changes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
@ryanwelcher ryanwelcher requested a review from youknowriad as a code owner Sep 4, 2020
@ryanwelcher ryanwelcher mentioned this pull request Sep 4, 2020
5 of 5 tasks complete
Copy link
Contributor

@draganescu draganescu left a comment

This is a good step forward towards better extensibility of the Widgets screen. Tested locally and nothing breaks with the addition.

@draganescu draganescu merged commit ca167e4 into WordPress:master Sep 11, 2020
14 checks passed
14 checks passed
Cancel Previous Runs
Details
Check Check
Details
build
Details
Admin - 1
Details
Compare performance with master
Details
test (gutenberg-editor-gallery)
Details
test (gutenberg-editor-gallery)
Details
All
Details
JavaScript
Details
Admin - 2
Details
PHP
Details
Admin - 3
Details
Mobile
Details
Admin - 4
Details
Widgets editor automation moved this from PRs in progress to Done Sep 11, 2020
@github-actions github-actions bot added this to the Gutenberg 9.0 milestone Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.