Skip to content

/ gutenberg Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compose: Add types to useFocusReturn #31949

Merged
merged 4 commits into from May 21, 2021
Merged

compose: Add types to useFocusReturn #31949

merged 4 commits into from May 21, 2021

Conversation

@sarayourfriend
Copy link
Contributor

@sarayourfriend sarayourfriend commented May 18, 2021

Description

Adds types to useFocusReturn.

It's a little messy I think and I'm unsure of the return type, whether it should be HTMLElement or potentially even just generic. I don't think it can be Node though otherwise you'll get a type error when you actually try to apply the ref that's returned 🤔

Part of #18838

How has this been tested?

Type checks pass. Also tested inline with a component that just uses the function and it works fine:

const Comp = () => {
  const ref = useFocusReturn();
  return <div ref={ ref } />;
}

The above produces no errors when typechecked.

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • [N/A] My code follows the accessibility standards.
  • [N/A] I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
@sarayourfriend sarayourfriend requested review from ciampo and tyxla May 18, 2021
@sarayourfriend sarayourfriend self-assigned this May 18, 2021
@sarayourfriend sarayourfriend requested a review from ajitbohra as a code owner May 18, 2021
@github-actions
Copy link

@github-actions github-actions bot commented May 18, 2021 •
edited

Size Change: +3.04 kB (0%)

Total Size: 1.62 MB

Filename Size Change
build/block-directory/index.js 6.61 kB -1 B (0%)
build/block-editor/index.js 119 kB +599 B (+1%)
build/block-editor/style-rtl.css 12.9 kB +41 B (0%)
build/block-editor/style.css 12.9 kB +46 B (0%)
build/block-library/blocks/button/style-rtl.css 603 B +2 B (0%)
build/block-library/blocks/button/style.css 602 B +2 B (0%)
build/block-library/blocks/cover/editor-rtl.css 644 B +1 B (0%)
build/block-library/blocks/cover/editor.css 646 B +1 B (0%)
build/block-library/blocks/cover/style-rtl.css 1.22 kB +3 B (0%)
build/block-library/blocks/cover/style.css 1.23 kB +3 B (0%)
build/block-library/blocks/freeform/editor-rtl.css 2.44 kB -4 B (0%)
build/block-library/blocks/freeform/editor.css 2.44 kB -4 B (0%)
build/block-library/blocks/gallery/style-rtl.css 1.06 kB +5 B (0%)
build/block-library/blocks/gallery/style.css 1.06 kB +6 B (+1%)
build/block-library/blocks/navigation/editor-rtl.css 1.54 kB +3 B (0%)
build/block-library/blocks/navigation/editor.css 1.54 kB +1 B (0%)
build/block-library/blocks/navigation/style-rtl.css 1.8 kB +22 B (+1%)
build/block-library/blocks/navigation/style.css 1.8 kB +22 B (+1%)
build/block-library/blocks/query-loop/editor-rtl.css 98 B +15 B (+18%) ⚠️
build/block-library/blocks/query-loop/editor.css 97 B +15 B (+18%) ⚠️
build/block-library/blocks/table/style-rtl.css 480 B -5 B (-1%)
build/block-library/blocks/table/style.css 480 B -5 B (-1%)
build/block-library/blocks/video/style-rtl.css 173 B +4 B (+2%)
build/block-library/blocks/video/style.css 173 B +4 B (+2%)
build/block-library/editor-rtl.css 9.93 kB +8 B (0%)
build/block-library/editor.css 9.92 kB +6 B (0%)
build/block-library/index.js 147 kB +527 B (0%)
build/block-library/style-rtl.css 10.3 kB +19 B (0%)
build/block-library/style.css 10.3 kB +19 B (0%)
build/blocks/index.js 47.2 kB +137 B (0%)
build/components/index.js 188 kB +423 B (0%)
build/components/style-rtl.css 16.2 kB +3 B (0%)
build/components/style.css 16.2 kB +8 B (0%)
build/compose/index.js 10 kB +57 B (+1%)
build/core-data/index.js 12.1 kB +12 B (0%)
build/customize-widgets/index.js 43.2 kB -3 B (0%)
build/edit-navigation/index.js 13.9 kB +311 B (+2%)
build/edit-navigation/style-rtl.css 3.08 kB +261 B (+9%) 🔍
build/edit-navigation/style.css 3.08 kB +260 B (+9%) 🔍
build/edit-post/index.js 335 kB +483 B (0%)
build/edit-post/style-rtl.css 6.81 kB +20 B (0%)
build/edit-post/style.css 6.8 kB +23 B (0%)
build/edit-site/index.js 25.8 kB -274 B (-1%)
build/edit-widgets/index.js 292 kB -2 B (0%)
build/editor/index.js 38.4 kB -33 B (0%)
build/format-library/index.js 5.66 kB -2 B (0%)
build/plugins/index.js 1.99 kB +1 B (0%)
build/reusable-blocks/index.js 2.54 kB -1 B (0%)
build/server-side-render/index.js 1.64 kB -2 B (0%)
build/widgets/index.js 1.66 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.12 kB 0 B
build/annotations/index.js 2.93 kB 0 B
build/api-fetch/index.js 2.42 kB 0 B
build/autop/index.js 2.28 kB 0 B
build/blob/index.js 673 B 0 B
build/block-directory/style-rtl.css 989 B 0 B
build/block-directory/style.css 990 B 0 B
build/block-library/blocks/archives/editor-rtl.css 61 B 0 B
build/block-library/blocks/archives/editor.css 60 B 0 B
build/block-library/blocks/audio/editor-rtl.css 58 B 0 B
build/block-library/blocks/audio/editor.css 58 B 0 B
build/block-library/blocks/audio/style-rtl.css 112 B 0 B
build/block-library/blocks/audio/style.css 112 B 0 B
build/block-library/blocks/block/editor-rtl.css 161 B 0 B
build/block-library/blocks/block/editor.css 161 B 0 B
build/block-library/blocks/button/editor-rtl.css 475 B 0 B
build/block-library/blocks/button/editor.css 474 B 0 B
build/block-library/blocks/buttons/editor-rtl.css 315 B 0 B
build/block-library/blocks/buttons/editor.css 315 B 0 B
build/block-library/blocks/buttons/style-rtl.css 375 B 0 B
build/block-library/blocks/buttons/style.css 375 B 0 B
build/block-library/blocks/calendar/style-rtl.css 208 B 0 B
build/block-library/blocks/calendar/style.css 208 B 0 B
build/block-library/blocks/categories/editor-rtl.css 84 B 0 B
build/block-library/blocks/categories/editor.css 83 B 0 B
build/block-library/blocks/categories/style-rtl.css 79 B 0 B
build/block-library/blocks/categories/style.css 79 B 0 B
build/block-library/blocks/code/style-rtl.css 90 B 0 B
build/block-library/blocks/code/style.css 90 B 0 B
build/block-library/blocks/columns/editor-rtl.css 190 B 0 B
build/block-library/blocks/columns/editor.css 190 B 0 B
build/block-library/blocks/columns/style-rtl.css 422 B 0 B
build/block-library/blocks/columns/style.css 422 B 0 B
build/block-library/blocks/embed/editor-rtl.css 486 B 0 B
build/block-library/blocks/embed/editor.css 486 B 0 B
build/block-library/blocks/embed/style-rtl.css 401 B 0 B
build/block-library/blocks/embed/style.css 400 B 0 B
build/block-library/blocks/file/editor-rtl.css 301 B 0 B
build/block-library/blocks/file/editor.css 300 B 0 B
build/block-library/blocks/file/frontend.js 771 B 0 B
build/block-library/blocks/file/style-rtl.css 255 B 0 B
build/block-library/blocks/file/style.css 255 B 0 B
build/block-library/blocks/gallery/editor-rtl.css 704 B 0 B
build/block-library/blocks/gallery/editor.css 705 B 0 B
build/block-library/blocks/group/editor-rtl.css 160 B 0 B
build/block-library/blocks/group/editor.css 160 B 0 B
build/block-library/blocks/group/style-rtl.css 57 B 0 B
build/block-library/blocks/group/style.css 57 B 0 B
build/block-library/blocks/heading/editor-rtl.css 129 B 0 B
build/block-library/blocks/heading/editor.css 129 B 0 B
build/block-library/blocks/heading/style-rtl.css 76 B 0 B
build/block-library/blocks/heading/style.css 76 B 0 B
build/block-library/blocks/home-link/style-rtl.css 259 B 0 B
build/block-library/blocks/home-link/style.css 259 B 0 B
build/block-library/blocks/html/editor-rtl.css 281 B 0 B
build/block-library/blocks/html/editor.css 281 B 0 B
build/block-library/blocks/image/editor-rtl.css 717 B 0 B
build/block-library/blocks/image/editor.css 716 B 0 B
build/block-library/blocks/image/style-rtl.css 481 B 0 B
build/block-library/blocks/image/style.css 485 B 0 B
build/block-library/blocks/latest-comments/style-rtl.css 281 B 0 B
build/block-library/blocks/latest-comments/style.css 282 B 0 B
build/block-library/blocks/latest-posts/editor-rtl.css 137 B 0 B
build/block-library/blocks/latest-posts/editor.css 137 B 0 B
build/block-library/blocks/latest-posts/style-rtl.css 523 B 0 B
build/block-library/blocks/latest-posts/style.css 522 B 0 B
build/block-library/blocks/legacy-widget/editor-rtl.css 557 B 0 B
build/block-library/blocks/legacy-widget/editor.css 557 B 0 B
build/block-library/blocks/list/style-rtl.css 63 B 0 B
build/block-library/blocks/list/style.css 63 B 0 B
build/block-library/blocks/media-text/editor-rtl.css 176 B 0 B
build/block-library/blocks/media-text/editor.css 176 B 0 B
build/block-library/blocks/media-text/style-rtl.css 492 B 0 B
build/block-library/blocks/media-text/style.css 489 B 0 B
build/block-library/blocks/more/editor-rtl.css 434 B 0 B
build/block-library/blocks/more/editor.css 434 B 0 B
build/block-library/blocks/navigation-link/editor-rtl.css 633 B 0 B
build/block-library/blocks/navigation-link/editor.css 634 B 0 B
build/block-library/blocks/navigation-link/style-rtl.css 94 B 0 B
build/block-library/blocks/navigation-link/style.css 94 B 0 B
build/block-library/blocks/nextpage/editor-rtl.css 395 B 0 B
build/block-library/blocks/nextpage/editor.css 395 B 0 B
build/block-library/blocks/page-list/editor-rtl.css 310 B 0 B
build/block-library/blocks/page-list/editor.css 311 B 0 B
build/block-library/blocks/page-list/style-rtl.css 233 B 0 B
build/block-library/blocks/page-list/style.css 233 B 0 B
build/block-library/blocks/paragraph/editor-rtl.css 157 B 0 B
build/block-library/blocks/paragraph/editor.css 157 B 0 B
build/block-library/blocks/paragraph/style-rtl.css 247 B 0 B
build/block-library/blocks/paragraph/style.css 248 B 0 B
build/block-library/blocks/post-author/editor-rtl.css 209 B 0 B
build/block-library/blocks/post-author/editor.css 209 B 0 B
build/block-library/blocks/post-author/style-rtl.css 183 B 0 B
build/block-library/blocks/post-author/style.css 184 B 0 B
build/block-library/blocks/post-comments-form/style-rtl.css 140 B 0 B
build/block-library/blocks/post-comments-form/style.css 140 B 0 B
build/block-library/blocks/post-comments/style-rtl.css 360 B 0 B
build/block-library/blocks/post-comments/style.css 359 B 0 B
build/block-library/blocks/post-content/editor-rtl.css 139 B 0 B
build/block-library/blocks/post-content/editor.css 139 B 0 B
build/block-library/blocks/post-excerpt/editor-rtl.css 73 B 0 B
build/block-library/blocks/post-excerpt/editor.css 73 B 0 B
build/block-library/blocks/post-excerpt/style-rtl.css 69 B 0 B
build/block-library/blocks/post-excerpt/style.css 69 B 0 B
build/block-library/blocks/post-featured-image/editor-rtl.css 338 B 0 B
build/block-library/blocks/post-featured-image/editor.css 338 B 0 B
build/block-library/blocks/post-featured-image/style-rtl.css 119 B 0 B
build/block-library/blocks/post-featured-image/style.css 119 B 0 B
build/block-library/blocks/post-title/style-rtl.css 60 B 0 B
build/block-library/blocks/post-title/style.css 60 B 0 B
build/block-library/blocks/preformatted/style-rtl.css 103 B 0 B
build/block-library/blocks/preformatted/style.css 103 B 0 B
build/block-library/blocks/pullquote/editor-rtl.css 183 B 0 B
build/block-library/blocks/pullquote/editor.css 183 B 0 B
build/block-library/blocks/pullquote/style-rtl.css 318 B 0 B
build/block-library/blocks/pullquote/style.css 318 B 0 B
build/block-library/blocks/query-loop/style-rtl.css 315 B 0 B
build/block-library/blocks/query-loop/style.css 317 B 0 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B 0 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B 0 B
build/block-library/blocks/query-pagination/editor-rtl.css 270 B 0 B
build/block-library/blocks/query-pagination/editor.css 262 B 0 B
build/block-library/blocks/query-pagination/style-rtl.css 168 B 0 B
build/block-library/blocks/query-pagination/style.css 168 B 0 B
build/block-library/blocks/query-title/editor-rtl.css 86 B 0 B
build/block-library/blocks/query-title/editor.css 86 B 0 B
build/block-library/blocks/query/editor-rtl.css 131 B 0 B
build/block-library/blocks/query/editor.css 132 B 0 B
build/block-library/blocks/quote/style-rtl.css 169 B 0 B
build/block-library/blocks/quote/style.css 169 B 0 B
build/block-library/blocks/rss/editor-rtl.css 201 B 0 B
build/block-library/blocks/rss/editor.css 202 B 0 B
build/block-library/blocks/rss/style-rtl.css 290 B 0 B
build/block-library/blocks/rss/style.css 290 B 0 B
build/block-library/blocks/search/editor-rtl.css 189 B 0 B
build/block-library/blocks/search/editor.css 189 B 0 B
build/block-library/blocks/search/style-rtl.css 359 B 0 B
build/block-library/blocks/search/style.css 362 B 0 B
build/block-library/blocks/separator/editor-rtl.css 99 B 0 B
build/block-library/blocks/separator/editor.css 99 B 0 B
build/block-library/blocks/separator/style-rtl.css 251 B 0 B
build/block-library/blocks/separator/style.css 251 B 0 B
build/block-library/blocks/shortcode/editor-rtl.css 512 B 0 B
build/block-library/blocks/shortcode/editor.css 512 B 0 B
build/block-library/blocks/site-logo/editor-rtl.css 440 B 0 B
build/block-library/blocks/site-logo/editor.css 441 B 0 B
build/block-library/blocks/site-logo/style-rtl.css 154 B 0 B
build/block-library/blocks/site-logo/style.css 154 B 0 B
build/block-library/blocks/social-link/editor-rtl.css 164 B 0 B
build/block-library/blocks/social-link/editor.css 165 B 0 B
build/block-library/blocks/social-links/editor-rtl.css 800 B 0 B
build/block-library/blocks/social-links/editor.css 799 B 0 B
build/block-library/blocks/social-links/style-rtl.css 1.32 kB 0 B
build/block-library/blocks/social-links/style.css 1.33 kB 0 B
build/block-library/blocks/spacer/editor-rtl.css 308 B 0 B
build/block-library/blocks/spacer/editor.css 308 B 0 B
build/block-library/blocks/spacer/style-rtl.css 48 B 0 B
build/block-library/blocks/spacer/style.css 48 B 0 B
build/block-library/blocks/table/editor-rtl.css 478 B 0 B
build/block-library/blocks/table/editor.css 478 B 0 B
build/block-library/blocks/tag-cloud/editor-rtl.css 118 B 0 B
build/block-library/blocks/tag-cloud/editor.css 118 B 0 B
build/block-library/blocks/tag-cloud/style-rtl.css 94 B 0 B
build/block-library/blocks/tag-cloud/style.css 94 B 0 B
build/block-library/blocks/template-part/editor-rtl.css 551 B 0 B
build/block-library/blocks/template-part/editor.css 550 B 0 B
build/block-library/blocks/term-description/editor-rtl.css 90 B 0 B
build/block-library/blocks/term-description/editor.css 90 B 0 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B 0 B
build/block-library/blocks/text-columns/editor.css 95 B 0 B
build/block-library/blocks/text-columns/style-rtl.css 166 B 0 B
build/block-library/blocks/text-columns/style.css 166 B 0 B
build/block-library/blocks/verse/style-rtl.css 87 B 0 B
build/block-library/blocks/verse/style.css 87 B 0 B
build/block-library/blocks/video/editor-rtl.css 569 B 0 B
build/block-library/blocks/video/editor.css 570 B 0 B
build/block-library/common-rtl.css 1.26 kB 0 B
build/block-library/common.css 1.26 kB 0 B
build/block-library/reset-rtl.css 506 B 0 B
build/block-library/reset.css 507 B 0 B
build/block-library/theme-rtl.css 692 B 0 B
build/block-library/theme.css 693 B 0 B
build/block-serialization-default-parser/index.js 1.29 kB 0 B
build/block-serialization-spec-parser/index.js 3.06 kB 0 B
build/customize-widgets/style-rtl.css 1.38 kB 0 B
build/customize-widgets/style.css 1.38 kB 0 B
build/data-controls/index.js 829 B 0 B
build/data/index.js 7.23 kB 0 B
build/date/index.js 31.8 kB 0 B
build/deprecated/index.js 739 B 0 B
build/dom-ready/index.js 577 B 0 B
build/dom/index.js 4.62 kB 0 B
build/edit-post/classic-rtl.css 454 B 0 B
build/edit-post/classic.css 454 B 0 B
build/edit-site/style-rtl.css 4.76 kB 0 B
build/edit-site/style.css 4.75 kB 0 B
build/edit-widgets/style-rtl.css 3.46 kB 0 B
build/edit-widgets/style.css 3.47 kB 0 B
build/editor/style-rtl.css 3.92 kB 0 B
build/editor/style.css 3.91 kB 0 B
build/element/index.js 3.44 kB 0 B
build/escape-html/index.js 739 B 0 B
build/format-library/style-rtl.css 637 B 0 B
build/format-library/style.css 639 B 0 B
build/hooks/index.js 1.76 kB 0 B
build/html-entities/index.js 627 B 0 B
build/i18n/index.js 3.73 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 1.65 kB 0 B
build/keycodes/index.js 1.43 kB 0 B
build/list-reusable-blocks/index.js 2.06 kB 0 B
build/list-reusable-blocks/style-rtl.css 629 B 0 B
build/list-reusable-blocks/style.css 628 B 0 B
build/media-utils/index.js 3.08 kB 0 B
build/navigation/index.js 2.85 kB 0 B
build/notices/index.js 1.07 kB 0 B
build/nux/index.js 2.31 kB 0 B
build/nux/style-rtl.css 718 B 0 B
build/nux/style.css 716 B 0 B
build/primitives/index.js 1.03 kB 0 B
build/priority-queue/index.js 791 B 0 B
build/react-i18n/index.js 923 B 0 B
build/redux-routine/index.js 2.82 kB 0 B
build/reusable-blocks/style-rtl.css 225 B 0 B
build/reusable-blocks/style.css 225 B 0 B
build/rich-text/index.js 10.7 kB 0 B
build/shortcode/index.js 1.68 kB 0 B
build/token-list/index.js 846 B 0 B
build/url/index.js 1.95 kB 0 B
build/viewport/index.js 1.28 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.24 kB 0 B

compressed-size-action

tyxla
tyxla reviewed May 19, 2021
View changes
packages/compose/src/hooks/use-focus-return/index.js Outdated
const isFocused = ref.current.contains(
ref.current.ownerDocument.activeElement
const isFocused = ref.current?.contains(
ref.current?.ownerDocument.activeElement ?? null
Copy link
Member

@tyxla tyxla May 19, 2021

Can we pass null to Node.contains()? In any case this case feels weird.

Copy link
Contributor Author

@sarayourfriend sarayourfriend May 19, 2021

You can, it accepts Node | null but not undefined.

Copy link
Member

@tyxla tyxla May 19, 2021

👍 Gotcha. Checking if a node contains null sounds like an oxymoron to me, but that's beyond the scale of this PR anyway.

packages/compose/src/hooks/use-focus-return/index.js Outdated
focusedBeforeMount.current = node.ownerDocument.activeElement;
focusedBeforeMount.current =
/** @type {HTMLElement | null} */ ( node.ownerDocument
.activeElement ) || undefined;
Copy link
Member

@tyxla tyxla May 19, 2021

Is there a reason to prefer || undefined here than ?? undefined? Also, why prefer undefined than potentially null here?

Copy link
Contributor Author

@sarayourfriend sarayourfriend May 19, 2021

None, I can change it to ?? just fine.

I used undefined because it matches the original default value on line 34. We could change it to null if we change the default value to null as well. Do you think that would be better?

Copy link
Contributor Author

@sarayourfriend sarayourfriend May 19, 2021

After speaking to @ciampo I'm going to go ahead and make the change to the default value of null instead of using undefined here. Should clean up the code a bit 🙂

Copy link
Member

@tyxla tyxla May 19, 2021

Thanks, I like that 👍

@sarayourfriend
compose: Add types to `useFocusReturn`
87f4168
@sarayourfriend
Slightly improve types
487570f
@sarayourfriend sarayourfriend force-pushed the add/types-compose-focus-return branch from 9ac5467 to 487570f May 19, 2021
@sarayourfriend
Use null as default value
9c069b5
tyxla
tyxla approved these changes May 19, 2021
View changes
Copy link
Member

@tyxla tyxla left a comment

I don't have anything to add here, this looks good 👍

@ciampo did you want to add anything before we 🚢 ?

@ciampo
Copy link
Contributor

@ciampo ciampo commented May 20, 2021 •
edited

@ciampo did you want to add anything before we 🚢 ?

Just added a minor comment but otherwise, I don't have anything else to add

PS: looks like the CI checks are not running?

@sarayourfriend @ciampo
Fix missing null type.
a5307b5 
Co-authored-by: Marco Ciampini <[email protected]>
@sarayourfriend sarayourfriend merged commit 7d5fa9d into trunk May 21, 2021
19 checks passed
@sarayourfriend sarayourfriend deleted the add/types-compose-focus-return branch May 21, 2021
@github-actions github-actions bot added this to the Gutenberg 10.8 milestone May 21, 2021
fullofcaffeine added a commit that referenced this issue May 22, 2021
@fullofcaffeine
Merge branch 'trunk' into try/minified-and-unminified-entries-webpack 1�7
2f71f41 
 1�7-take-2

* trunk: (57 commits)
  Image block: fix cover transform and excessive re-rendering (#32102)
  compose: Add types to useMergeRefs (#31939)
  Navigation: Fix collapsing regression. (#32081)
  components: Promote Elevation (#31614)
  compose: Add types to useReducedMotion and useMediaQuery (#31941)
  Update the graphic that appears in the Template Editor welcome guide (#32055)
  Block Navigation: use CSS for indentation with known max indent instead of spacer divs (#32063)
  Fix broken template part converter modal styles. (#32097)
  compose: Add types to `usePrevious` (#31944)
  components: Add ZStack (#31613)
  components: Fix Shortcut polymorphism (#31555)
  compose: Add types to `useFocusReturn` (#31949)
  compose: Add types to `useDebounce` (#32015)
  List View: Simplify the BlockNavigation component (#31290)
  Remove query context leftovers (#32093)
  Remove filter_var from blocks (#32046)
  Templates: Remove now-obsolete gutenberg_get_template_paths() (#32066)
  [RNMobile] Enable reusable block only in WP.com sites (#31744)
  Rename ViewOwnProps to PolymorphicComponentProps (#32053)
  Rich text: remove inline display warning (#32013)
  ...
stacimc added a commit to stacimc/gutenberg that referenced this issue May 25, 2021
@sarayourfriend @ciampo @stacimc
compose: Add types to useFocusReturn (WordPress#31949)
081193b 
* compose: Add types to `useFocusReturn`

* Slightly improve types

* Use null as default value

* Fix missing null type.

Co-authored-by: Marco Ciampini <[email protected]>

Co-authored-by: Marco Ciampini <[email protected]>
getdave added a commit that referenced this issue May 27, 2021
@sarayourfriend @ciampo @getdave
compose: Add types to useFocusReturn (#31949)
86344f1 
* compose: Add types to `useFocusReturn`

* Slightly improve types

* Use null as default value

* Fix missing null type.

Co-authored-by: Marco Ciampini <[email protected]>

Co-authored-by: Marco Ciampini <[email protected]>
vcanales added a commit that referenced this issue Jul 7, 2021
@sarayourfriend @ciampo @vcanales
compose: Add types to useFocusReturn (#31949)
d3aa783 
* compose: Add types to `useFocusReturn`

* Slightly improve types

* Use null as default value

* Fix missing null type.

Co-authored-by: Marco Ciampini <[email protected]>

Co-authored-by: Marco Ciampini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo

@tyxla tyxla

@ajitbohra ajitbohra

Assignees

@sarayourfriend sarayourfriend

Labels
[Package] Compose [Type] Code Quality
Projects
None yet
Milestone
Gutenberg 10.8
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@sarayourfriend @ciampo @tyxla