WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#35875 closed defect (bug) (fixed)

Customizer, Preview: Empty customizer preview on iOS

Reported by: ryan Owned by: ryan
Milestone: 4.5 Priority: normal
Severity: normal Version: 4.6
Component: Customize Keywords: has-patch needs-testing
Focuses: Cc:

Description (last modified by ryan)

Somewhere between r36527 and r36582, customizer preview broke on my iPhone 6+. Preview is blank.

https://core.trac.wordpress.org/raw-attachment/ticket/35875/IMG_8060.PNG

Attachments (4)

IMG_8052.PNG​ (85.3 KB) - added by ryan 6 years ago.
Blank preview on iPhone 6+
IMG_8060.PNG​ (84.1 KB) - added by ryan 6 years ago.
Another site with blank preview on iPhone 6+
35875.diff​ (438 bytes) - added by adamsilverstein 6 years ago.
customizer preview iphone 6 plus.PNG​ (162.6 KB) - added by ryan 6 years ago.
Preview looks good on an iPhone 6+ with 35875.diff

Download all attachments as: .zip

Change History (20)

@ryan
6 years ago

Blank preview on iPhone 6+

@ryan
6 years ago

Another site with blank preview on iPhone 6+

#1 @westonruter
6 years ago

  • Owner set to westonruter
  • Status changed from new to accepted

I bet it has something to do with the device preview functionality (#31195) and [36532].

#2 @ryan
6 years ago

  • Description modified (diff)

This ticket was mentioned in ​Slack in #core-customize by adamsilverstein. ​View the logs.
6 years ago

@adamsilverstein
6 years ago

#4 @adamsilverstein
6 years ago

35875.diff​ fixes ios display in chrome debugger, not certain why the removed style is there so trying to track it down. @ryan can you test please?

#5 @adamsilverstein
6 years ago

  • Keywords has-patch 2nd-opinion added

#6 @adamsilverstein
6 years ago

The problematic style was added in r21014 for #20805. It may no longer be needed; testing on actual devices will verify this.

#7 @westonruter
6 years ago

  • Keywords needs-testing added
  • Owner changed from westonruter to ryan
  • Status changed from accepted to assigned

This ticket was mentioned in ​Slack in #core-flow by boren. ​View the logs.
6 years ago

@ryan
6 years ago

Preview looks good on an iPhone 6+ with 35875.diff

#9 @ryan
6 years ago

Also tested on Macnchrome, Macnfirefox, iPad Air, Nexus 5, iPhone 5.

#11 follow-up: @westonruter
6 years ago

  • Keywords 2nd-opinion removed

@ryan and the preview was still scrollable on iOS, as this was the reason for this iOS-specific style rule to be added in #20805?

This ticket was mentioned in ​Slack in #core by westonruter. ​View the logs.
6 years ago

This ticket was mentioned in ​Slack in #core-flow by boren. ​View the logs.
6 years ago

#14 in reply to: ↑ 11 @ryan
6 years ago

Replying to westonruter:

@ryan and the preview was still scrollable on iOS, as this was the reason for this iOS-specific style rule to be added in #20805?

Yes, still scrollable. I just double checked on an iPhone 6+.

This ticket was mentioned in ​Slack in #core by boren. ​View the logs.
6 years ago

#16 @westonruter
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 36804:

Customize: Fix visibility of preview in iOS.

Removes CSS rule added in [21014] that is now obsolete.

Props adamsilverstein.
See #20805.
Fixes #35875.

Note: See TracTickets for help on using tickets.