avoid_blog_page_permalink_collision shouldn't change the post_name when the page has a parent.

[stormrockwell]

How to reproduce:

Create multisite install (subdirectory)
Add subsite "bar"
On the main site, create a page for "foo" and a page for "bar" with the parent "foo"

When trying to publish that page you will get /foo/bar{rand1-10}.

[SergeyBiryukov]

Hi there, welcome back to WordPress Trac!

Thanks for the ticket and the patch, this makes sense at a glance.

A unit test to confirm the fix would also be great.

[stormrockwell]

Add unit test

[stormrockwell]

This was my first go at unit tests. Any feedback is much appreciated.

[stormrockwell]

Unit tests & fix typo in comment.

[stormrockwell]

Change the class name

[helen]

Don't want to go changing these internals in late beta, moving out of 5.6 and assigning the reported version to 5.5 although I imagine this has existed since long before that. If this really is new to trunk please feel free to move back and kindly add more context around what change caused it.

[stormrockwell]

Is there anything else you need from me on this?

[terriann]

This defect still exists in 5.8.1, echoing the last question from @stormrockwell - is there anything else that needs to be done to get this into a future release plan?

[whyisjake]

#44112 was marked as a duplicate.

[whyisjake]

Tests look great, marking for commit.

[whyisjake]

In 51855:

Posts, Post Types: Don't add a trailing number when there is a unique post parent.

WordPress tries to avoid an issue where slugs might match an existing slug of a page/post.
If we are in a hierarchical post type, there will be a level, and we can leave it the same.

Props stormrockwell, SergeyBiryukov, terriann, tubys, jeremyfelt, Daschmi, MaximeCulea, knutsp, whyisjake.
Fixes #51147.
See also #44112 and #45260.

[hellofromTonya]

Reopening as [51855] needs a follow-up to upgrade the test case fixture methods from camelCase to snake_case, i.e. setUp() to set_up() etc. I'll fix shortly.

Trac ticket: https://core.trac.wordpress.org/ticket/51147

[hellofromTonya]

In 51857:

Build/Test Tools: Upgrades Tests_Multisite_MS_Permalink_Collision fixture methods and strict assertion.

Improvements include:

• Upgrades the test fixture methods to the new snake_case methods.
• Reorders the fixture methods for consistency.
• Uses strict assertions of assertSame and assertNotSame.

Follow-up to [51855-51856].

Props hellofromTonya.
See #51147.

[hellofromTonya]

Reclosing with [51857].

[prbot]

​hellofromtonya commented on ​PR #1699:

Committed with changeset https://core.trac.wordpress.org/changeset/51857.

[SergeyBiryukov]

In 51859:

Tests: Further improve the tests for avoid_blog_page_permalink_collision():

• Rename the test filename and class to match the name of the function being tested.
• Remove unnecessary setUp() and tearDown() methods.
• Replace the only test group with post.

Follow-up to [51855-51857].

See #51147.