775: Set the initial hidden state for the bulk priority select with CSS #777
Conversation
Also, hide the priority action for no-JS. Fixes #775.
toolstack
changed the title
| @@ -1,4 +1,7 @@ | |||
| jQuery(function($) { | |||
| var $bulkActions = $( '#bulk-action' ), | |||
| $bulkPriority = $( '#bulk-priority' ); | |||
toolstack
Jul 2, 2017
Contributor
Does this need a var statement in front of it?
Does this need a var statement in front of it?
swissspidy
Jul 2, 2017
Member
No, because of the comma this is the same as var $bulkActions = …; var $bulkPriority = …;
No, because of the comma this is the same as var $bulkActions = …; var $bulkPriority = …;
| @@ -34,7 +34,7 @@ | |||
| <option value="reject"><?php _e( 'Reject', 'glotpress' ); ?></option> | |||
| <option value="fuzzy"><?php _e( 'Fuzzy', 'glotpress' ); ?></option> | |||
| <?php if( $can_write ) : ?> | |||
| <option value="set-priority"><?php _e( 'Set Priority', 'glotpress' ); ?></option> | |||
| <option value="set-priority" class="hide-if-no-js"><?php _e( 'Set Priority', 'glotpress' ); ?></option> | |||
toolstack
Jul 2, 2017
Contributor
Should we hide this without JS? A non-JS user would never be able to set the bulk priority if we do. Though, I think it's safe to say that JS is a requirement for GP :)
Should we hide this without JS? A non-JS user would never be able to set the bulk priority if we do. Though, I think it's safe to say that JS is a requirement for GP :)
ocean90
Jul 2, 2017
Author
Member
I think it's safe to say that JS is a requirement for GP
It is. You can't submit any translations without JS because the editor isn't visible. 🙃
I think it's safe to say that JS is a requirement for GP
It is. You can't submit any translations without JS because the editor isn't visible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Also, hide the priority action for no-JS.
Fixes #775.