[Bug] Use camelcase in prop names

[dhruvkb]

Description

These components use the string 'URL' in the prop name.

openverse-frontend/src/components/ImageDetails/ImageInfo.vue

Line 65 in 428be35

'ccLicenseURL',

openverse-frontend/src/components/ImageDetails/ImageAttribution.vue

Line 24 in 428be35

ccLicenseURL: String,

openverse-frontend/src/components/MediaInfo/MediaLicense.vue

Line 72 in 428be35

licenseURL: String,

openverse-frontend/src/components/MediaInfo/CopyLicense.vue

Line 188 in 428be35

openverseLicenseURL: String,

This leads to the following syntax where the component is used with props:

<Component :something-something-u-r-l="value"/>

This is not looking good. Changing the props from 'URL' to 'Url' would fix this.

Resolution

• 🙋 I would be interested in resolving this bug.

[theshakeabhi]

I have been going through the code in the main and I found these:
ccLicenseURL has been used 20 times in 9 different files
licenseURL has been used 14 times in 5 different files
openverseLicenseURL has not been used till now.

Should one changes every occurance of it?

[krysal]

@theshakeabhi that is correct, it should be changed in all places to keep uniformity. Contributions to this are very welcome!

[theshakeabhi]

@krysal, these changes that @dhruvkb mentioned is on a specific branch https://github.com/WordPress/openverse-frontend/tree/428be354eada6b29dc3d63f21c7960e42386b423. So should I pull this branch and make this as base branch and make modification or should I take the main branch as the base branch?

[dhruvkb]

@theshakeabhi Make the changes on main. I used the absolute commit hash so that the issue remains valid after the fix is pushed.

[theshakeabhi]

@dhruvkb That's intresting. Thank you directing me.