Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add font size control for heading block #21431

Merged
merged 1 commit into from Apr 8, 2020
Merged

Add font size control for heading block #21431

merged 1 commit into from Apr 8, 2020

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Apr 6, 2020 •
edited

Depends on #21428 which should land first.

This PR adds support for font-sizes at the heading block by leveraging the font size support key recently landed at #21153

200408-1047-heading-font-size

How to test

  • Apply this PR and #21428
  • Add some heading blocks and test that a new font size control is present in the block inspector.
  • Test that it works as expected (choose a preset font, custom, check that it works in the front-end, etc).

@oandregal oandregal changed the title Add font size headings Add font size control for heading block Apr 6, 2020
@oandregal oandregal requested review from ItsJonQ and youknowriad Apr 6, 2020
@oandregal oandregal self-assigned this Apr 6, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Apr 6, 2020 •
edited

Size Change: +6 B (0%)

Total Size: 889 kB

Filename Size Change
build/block-library/index.js 110 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.02 kB 0 B
build/annotations/index.js 3.4 kB 0 B
build/api-fetch/index.js 3.79 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.03 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 102 kB 0 B
build/block-editor/style-rtl.css 10.2 kB 0 B
build/block-editor/style.css 10.2 kB 0 B
build/block-library/editor-rtl.css 7.22 kB 0 B
build/block-library/editor.css 7.22 kB 0 B
build/block-library/style-rtl.css 7.42 kB 0 B
build/block-library/style.css 7.43 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/index.js 195 kB 0 B
build/components/style-rtl.css 16.6 kB 0 B
build/components/style.css 16.5 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/core-data/index.js 10.7 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.23 kB 0 B
build/date/index.js 5.36 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.05 kB 0 B
build/edit-navigation/index.js 2.75 kB 0 B
build/edit-navigation/style-rtl.css 279 B 0 B
build/edit-navigation/style.css 280 B 0 B
build/edit-post/index.js 92.9 kB 0 B
build/edit-post/style-rtl.css 12.3 kB 0 B
build/edit-post/style.css 12.3 kB 0 B
build/edit-site/index.js 10.1 kB 0 B
build/edit-site/style-rtl.css 5.02 kB 0 B
build/edit-site/style.css 5.02 kB 0 B
build/edit-widgets/index.js 7.17 kB 0 B
build/edit-widgets/style-rtl.css 3.74 kB 0 B
build/edit-widgets/style.css 3.73 kB 0 B
build/editor/editor-styles-rtl.css 428 B 0 B
build/editor/editor-styles.css 431 B 0 B
build/editor/index.js 42.8 kB 0 B
build/editor/style-rtl.css 3.49 kB 0 B
build/editor/style.css 3.49 kB 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 6.95 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.7 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.84 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.5 kB 0 B
build/server-side-render/index.js 2.54 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.28 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.6 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@oandregal oandregal force-pushed the add/font-size-headings branch from 2f2a1a4 to 43e94ca Compare Apr 8, 2020
youknowriad
youknowriad approved these changes Apr 8, 2020
View changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Small PR, big feature :P

@oandregal oandregal force-pushed the add/font-size-headings branch from 43e94ca to c947ffa Compare Apr 8, 2020
@oandregal oandregal merged commit 7db547c into master Apr 8, 2020
3 checks passed
@oandregal oandregal deleted the add/font-size-headings branch Apr 8, 2020
@github-actions github-actions bot added this to the Gutenberg 7.9 milestone Apr 8, 2020
@oandregal
Copy link
Member Author

@oandregal oandregal commented Apr 8, 2020

Small PR, big feature :P

The best ones!

@oandregal oandregal mentioned this pull request May 29, 2020
Closed
@mtias mtias mentioned this pull request May 29, 2020
Closed
82 tasks
@dianeco
Copy link

@dianeco dianeco commented Jun 18, 2020

@nosolosw Is there a way to define different preset values for different blocks? For example, is it possible to have the preset size values of the Heading block different than the preset size values of the Paragraph block? Currently, the Large and Huge values for the Heading Block are smaller than their default one, which is surprising for the user.

@oandregal
Copy link
Member Author

@oandregal oandregal commented Jun 18, 2020

Is there a way to define different preset values for different blocks? For example, is it possible to have the preset size values of the Heading block different than the preset size values of the Paragraph block?

That's on the roadmap, but it's not yet implemented.

Currently, the Large and Huge values for the Heading Block are smaller than their default one, which is surprising for the user.

This is something that is theme-specific, so it depends on the font-sizes themes add + how they decide to style the heading elements that don't have any style assigned yet (the default). I've checked TwentyNineteen and TwentyTwenty and both seem to do what you report. Were those the themes you tested? If so, perhaps it's best to search and comment on their issue tracker (twenty-nineteen, twenty-twenty). I hope this is helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad

@ajitbohra ajitbohra

@jorgefilipecosta jorgefilipecosta

@Soean Soean

@talldan talldan

@ItsJonQ ItsJonQ

Assignees

@oandregal oandregal

Labels
[Block] Heading Global Styles [Type] Feature
Projects
None yet
Milestone
Gutenberg 7.9
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@oandregal @dianeco @youknowriad @ItsJonQ