Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documentation on how to update post meta values from a block. #21155

Merged
merged 2 commits into from Mar 26, 2020
Merged

Update Documentation on how to update post meta values from a block. #21155

merged 2 commits into from Mar 26, 2020

Conversation

@jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Mar 25, 2020

Description

The meta attributes were deprecated, but our docs were not updated.
This PR updates the tutorial on how to create a meta block to use the new mechanisms.
@jorgefilipecosta
Update Documentation on how to update post meta values from a block.
2ebccbc
@jorgefilipecosta jorgefilipecosta added this to Needs Review in WordPress 5.4 Must Have Mar 25, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Mar 25, 2020 •
edited

Size Change: -2.83 kB (0%)

Total Size: 857 kB

Filename Size Change
build/block-editor/index.js 101 kB -675 B (0%)
build/block-editor/style-rtl.css 10.9 kB -25 B (0%)
build/block-editor/style.css 10.9 kB -27 B (0%)
build/block-library/index.js 110 kB +5 B (0%)
build/block-library/style-rtl.css 7.43 kB -4 B (0%)
build/block-library/style.css 7.44 kB -5 B (0%)
build/components/index.js 191 kB +155 B (0%)
build/edit-post/index.js 91.2 kB +17 B (0%)
build/edit-post/style-rtl.css 8.43 kB -38 B (0%)
build/edit-post/style.css 8.43 kB -37 B (0%)
build/edit-site/index.js 6.71 kB -6 B (0%)
build/edit-site/style-rtl.css 2.91 kB +27 B (0%)
build/edit-site/style.css 2.9 kB +24 B (0%)
build/edit-widgets/style-rtl.css 2.57 kB -12 B (0%)
build/edit-widgets/style.css 2.57 kB -12 B (0%)
build/editor/index.js 42.8 kB -1 kB (2%)
build/editor/style-rtl.css 3.38 kB -611 B (18%) 👏
build/editor/style.css 3.38 kB -600 B (17%) 👏
build/i18n/index.js 3.49 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 998 B 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-library/editor-rtl.css 7.22 kB 0 B
build/block-library/editor.css 7.23 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.25 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-widgets/index.js 4.43 kB 0 B
build/editor/editor-styles-rtl.css 428 B 0 B
build/editor/editor-styles.css 431 B 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 6.95 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 622 B 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.69 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.84 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 781 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.5 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@ajitbohra
ajitbohra reviewed Mar 26, 2020
View changes
docs/designers-developers/developers/tutorials/metabox/meta-block-3-add.md Outdated Show resolved Hide resolved
@jorgefilipecosta @ajitbohra
Update docs/designers-developers/developers/tutorials/metabox/meta-bl…
cfe55a9 
…ock-3-add.md

Co-Authored-By: Ajit Bohra <[email protected]>
@jorgefilipecosta jorgefilipecosta merged commit 1441a36 into master Mar 26, 2020
2 of 3 checks passed
2 of 3 checks passed
@github-actions
build
Details
@github-actions
pull-request-automation
Details
@travis-ci
Travis CI - Pull Request Build Failed
Details
WordPress 5.4 Must Have automation moved this from Needs Review to Done Mar 26, 2020
@jorgefilipecosta jorgefilipecosta deleted the update/documentation-on-how-to-change-metavalues-from-a-block branch Mar 26, 2020
@github-actions github-actions bot added this to the Gutenberg 7.9 milestone Mar 26, 2020
@mgburns
Copy link

@mgburns mgburns commented Mar 27, 2020

@jorgefilipecosta Just a heads up that I attempted to follow the page sourced from this guide yesterday with WP 5.3.2 and it failed due to useEntityProp being undefined:
https://developer.wordpress.org/block-editor/tutorials/metabox/meta-block-3-add/

Is it normal workflow to update the dev docs with Gutenberg features that haven't landed in core yet?

@jorgefilipecosta
Copy link
Member Author

@jorgefilipecosta jorgefilipecosta commented Mar 27, 2020

Hi @mgburns, yes, we usually update the documentation in the plugin even for changes that are not yet part of the last release (e.g., things that are only available in the plugin).
This process is far from perfect, and we need some way to specify which version the documentation refers too. I'm sorry for the trouble caused.

@atachibana atachibana mentioned this pull request Apr 26, 2020
Closed
@alex-418
Copy link

@alex-418 alex-418 commented May 19, 2020

Hi, just wanted to note the developer handbook still uses the deprecated meta attributes instead of this new mechanism: https://developer.wordpress.org/block-editor/tutorials/metabox/meta-block-3-add/

@TimothyBJacobs
Copy link
Member

@TimothyBJacobs TimothyBJacobs commented Mar 28, 2021

@jorgefilipecosta Yeah, this is confusing that meta attributes are still recommended here as well: https://developer.wordpress.org/block-editor/reference-guides/block-api/block-attributes/#meta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra

@chrisvanpatten chrisvanpatten

@mkaz mkaz

@youknowriad youknowriad

Assignees
No one assigned
Labels
[Type] Documentation
Projects
No open projects
WordPress 5.4 Must Have
  
Done
Milestone
Gutenberg 7.9
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@jorgefilipecosta @mgburns @alex-418 @TimothyBJacobs @ajitbohra