Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'It's Time' pattern #21132

Merged
merged 1 commit into from Mar 30, 2020
Merged

Add 'It's Time' pattern #21132

merged 1 commit into from Mar 30, 2020

Conversation

enriquesanchez
Copy link
Contributor

@enriquesanchez enriquesanchez commented Mar 25, 2020

Adds a block pattern for #20345.

Screen Shot 2020-03-24 at 11 42 58

@enriquesanchez enriquesanchez self-assigned this Mar 25, 2020
@enriquesanchez enriquesanchez added this to In progress in Block Patterns via automation Mar 25, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Mar 25, 2020

Size Change: 0 B

Total Size: 859 kB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 998 B 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-editor/index.js 102 kB 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 7.24 kB 0 B
build/block-library/editor.css 7.24 kB 0 B
build/block-library/index.js 110 kB 0 B
build/block-library/style-rtl.css 7.43 kB 0 B
build/block-library/style.css 7.44 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/index.js 191 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.25 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.2 kB 0 B
build/edit-post/style-rtl.css 8.47 kB 0 B
build/edit-post/style.css 8.46 kB 0 B
build/edit-site/index.js 6.72 kB 0 B
build/edit-site/style-rtl.css 2.88 kB 0 B
build/edit-site/style.css 2.88 kB 0 B
build/edit-widgets/index.js 4.43 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 428 B 0 B
build/editor/editor-styles.css 431 B 0 B
build/editor/index.js 43.8 kB 0 B
build/editor/style-rtl.css 4 kB 0 B
build/editor/style.css 3.98 kB 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 6.95 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.69 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.84 kB 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 781 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.4 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

Block Patterns automation moved this from In progress to Reviewer approved Mar 25, 2020
mtias
mtias approved these changes Mar 25, 2020
View changes
@mtias
Copy link
Contributor

@mtias mtias commented Mar 28, 2020

Let's get this one in @enriquesanchez :)

@enriquesanchez enriquesanchez merged commit fe06586 into master Mar 30, 2020
4 checks passed
Block Patterns automation moved this from Reviewer approved to Done Mar 30, 2020
@enriquesanchez enriquesanchez deleted the add/its-time-pattern branch Mar 30, 2020
@github-actions github-actions bot added this to the Gutenberg 7.9 milestone Mar 30, 2020
@mtias
Copy link
Contributor

@mtias mtias commented Mar 31, 2020

This one should have some line-height adjustments for when it breaks into two lines:

image

@mtias
Copy link
Contributor

@mtias mtias commented Mar 31, 2020

@enriquesanchez also why is there an empty column on the left set to zero value?

image

@mtias
Copy link
Contributor

@mtias mtias commented Mar 31, 2020

We should also really not do this :) A spacer would be better.

image

@enriquesanchez
Copy link
Contributor Author

@enriquesanchez enriquesanchez commented Mar 31, 2020

@mtias oh, I totally forgot about that hidden "space" :) I was messing with and trying different ways of aligning things. I'll open a new PR to fix that and adjust the line-height.

As for the empty column, it was recommended to me as a hack to to have the text expand full width. If I were to use a paragraph block, its width would be very narrow and limiting.

@enriquesanchez enriquesanchez mentioned this pull request Mar 31, 2020
Closed
@ZebulanStanphill
Copy link
Member

@ZebulanStanphill ZebulanStanphill commented Mar 31, 2020

As for the empty column, it was recommended to me as a hack to to have the text expand full width. If I were to use a paragraph block, its width would be very narrow and limiting.

Huh? Why would it be narrow?

@oandregal oandregal mentioned this pull request Apr 7, 2020
Merged
@ellatrix ellatrix mentioned this pull request Jun 16, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtias mtias

@youknowriad youknowriad

@TimothyBJacobs TimothyBJacobs

Assignees

@enriquesanchez enriquesanchez

Labels
[Feature] Patterns
Projects
No open projects
Block Patterns
  
Done
Milestone
Gutenberg 7.9
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@enriquesanchez @mtias @ZebulanStanphill