Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the old block preview implementation #21096

Merged
merged 1 commit into from Mar 26, 2020
Merged

Conversation

@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Mar 24, 2020

In #21014 We removed the old scaled block preview usage and switched to auto-height by default.
In this PR, I'm removing the old implementation entirely as it's more complex, more cumbersome without a big additional value.

I'm adding a tentative "Needs devnote" to document this change.

@github-actions
Copy link

@github-actions github-actions bot commented Mar 24, 2020

Size Change: -627 B (0%)

Total Size: 858 kB

Filename Size Change
build/block-editor/index.js 100 kB -557 B (0%)
build/block-editor/style-rtl.css 11 kB -28 B (0%)
build/block-editor/style.css 11 kB -29 B (0%)
build/block-library/index.js 110 kB -7 B (0%)
build/components/index.js 191 kB +10 B (0%)
build/compose/index.js 6.21 kB -1 B
build/data/index.js 8.25 kB -1 B
build/edit-post/index.js 91.2 kB -1 B
build/edit-site/index.js 6.71 kB -7 B (0%)
build/edit-widgets/index.js 4.43 kB -3 B (0%)
build/editor/index.js 43.8 kB -5 B (0%)
build/element/index.js 4.44 kB +1 B
build/format-library/index.js 6.95 kB -2 B (0%)
build/keyboard-shortcuts/index.js 2.3 kB +1 B
build/list-reusable-blocks/index.js 2.99 kB +2 B (0%)
build/media-utils/index.js 4.84 kB +2 B (0%)
build/server-side-render/index.js 2.55 kB -1 B
build/viewport/index.js 1.61 kB -1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 998 B 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-library/editor-rtl.css 7.24 kB 0 B
build/block-library/editor.css 7.24 kB 0 B
build/block-library/style-rtl.css 7.41 kB 0 B
build/block-library/style.css 7.42 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.7 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/style-rtl.css 8.47 kB 0 B
build/edit-post/style.css 8.46 kB 0 B
build/edit-site/style-rtl.css 2.88 kB 0 B
build/edit-site/style.css 2.88 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/editor/style-rtl.css 4 kB 0 B
build/editor/style.css 3.98 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keycodes/index.js 1.69 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/notices/index.js 1.57 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/primitives/index.js 1.5 kB 0 B
build/priority-queue/index.js 781 B 0 B
build/redux-routine/index.js 2.84 kB 0 B
build/rich-text/index.js 14.4 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@youknowriad youknowriad merged commit ab3bed4 into master Mar 26, 2020
3 of 4 checks passed
3 of 4 checks passed
@github-actions[bot]
build
Details
@github-actions[bot]
pull-request-automation
Details
@github-actions[bot]
pull-request-automation
Details
@travis-ci[bot]
Travis CI - Pull Request Build Errored
Details
@youknowriad youknowriad deleted the remove/scaled-preview branch Mar 26, 2020
@github-actions github-actions bot added this to the Gutenberg 7.9 milestone Mar 26, 2020
@ellatrix ellatrix mentioned this pull request Jul 3, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant