Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact Support from inside editor #3975

Merged
merged 20 commits into from Sep 30, 2021
Merged

Contact Support from inside editor #3975

merged 20 commits into from Sep 30, 2021

Conversation

Reviewers

@hypest hypest

@fluiddot fluiddot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.63.0 (18.4)
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@twstokes @hypest @fluiddot
@twstokes
Copy link
Contributor

@twstokes twstokes commented Sep 16, 2021 •
edited
Loading

This PR enables developing the feature to contact support from inside the editor for WPiOS and WPAndroid.

To test: Follow instructions in the Gutenberg PR.

Related PRs

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.
twstokes added 2 commits Sep 16, 2021
@twstokes
Point to Gutenberg fork
b7fec23
@twstokes
Update Gutenberg fork ref
472f5a7
@twstokes twstokes marked this pull request as draft Sep 17, 2021
@twstokes
Update Gutenberg fork ref.
dceb2fb
@peril-wordpress-mobile
Copy link

@peril-wordpress-mobile peril-wordpress-mobile bot commented Sep 17, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Loading

@twstokes
Update Gutenberg ref.
a0bd8e0
@twstokes twstokes mentioned this pull request Sep 21, 2021
Merged
7 tasks
@twstokes twstokes changed the title [WIP] Launch support from inside editor [Gutenberg] Contact Support from inside editor Sep 21, 2021
@twstokes twstokes changed the title [Gutenberg] Contact Support from inside editor Contact Support from inside editor Sep 21, 2021
@twstokes
Update release notes.
ed04673
@twstokes twstokes marked this pull request as ready for review Sep 21, 2021
@twstokes twstokes requested a review from hypest Sep 21, 2021
@twstokes twstokes mentioned this pull request Sep 21, 2021
Merged
4 tasks
@hypest hypest mentioned this pull request Sep 21, 2021
Merged
3 tasks
hypest
hypest reviewed Sep 21, 2021
View changes
RELEASE-NOTES.txt Outdated Show resolved Hide resolved
Loading
hypest and others added 5 commits Sep 21, 2021
@hypest
Empty commit to trigger S3 publishing jobs
7b55ab5
@twstokes
Make release note more succinct.
827cae9
@twstokes
Update Gutenberg ref.
27f09cd
@twstokes
Update Gutenberg ref.
39e2c76
@twstokes
Merge remote-tracking branch 'origin/develop' into try/launch-support…
df1f383 
…-from-inside-editor-2
hypest
hypest approved these changes Sep 23, 2021
View changes
Copy link
Contributor

@hypest hypest left a comment

LGTM! I'm "approving" this PR to make it clear and yeah, besides updating the Gutenberg hash we'll need to revert the submodule pointer after we get the Gutenberg PR merged.

Loading

twstokes
twstokes reviewed Sep 24, 2021
View changes
bundle/ios/GutenbergNativeTranslations.swift Outdated Show resolved Hide resolved
Loading
@twstokes
Generate bundle.
961edcd
@twstokes twstokes force-pushed the try/launch-support-from-inside-editor-2 branch from 4659ce0 to 961edcd Sep 24, 2021
@hypest
Copy link
Contributor

@hypest hypest commented Sep 27, 2021 •
edited
Loading

👋 @twstokes , looks like all feedback has been addressed in this PR and the WP app PRs also got a green light from reviewers so, wdyt about resuming the merge domino? First step in that direction would be to update this PR to point to Gutenberg's PR and the merged (or later) commit. Then we'll smoke test the main app PRs to avoid having something obvious regressed and merge the gb-mobile PR. We'll need to tag the merged gb-mobile state with an -alpha tag to update in the main apps. Let me know if you need me to elaborate on any of that, thanks!

Edit: sorry, upon closer look, there's some pending (design) review on the Gutenberg PR so, let's hold of until @kyleaparker gets the chance to have another pass.

Loading

twstokes added 2 commits Sep 27, 2021
@twstokes
Update Gutenberg ref.
6231315
@twstokes
Generate bundle.
6ee727e
@twstokes twstokes added this to the 1.63.0 (18.4) milestone Sep 30, 2021
twstokes added 2 commits Sep 30, 2021
@twstokes
Point back to main Gutenberg repo.
4cb8ae9
@twstokes
Update Gutenberg ref after merge.
dce2718
twstokes added 3 commits Sep 30, 2021
@twstokes
Merge remote-tracking branch 'origin/develop' into try/launch-support…
9d8f927 
…-from-inside-editor-2
@twstokes
Regenerate bundle.
558ba69
@twstokes
Update Gutenberg ref.
31299b0
@twstokes
Copy link
Contributor Author

@twstokes twstokes commented Sep 30, 2021

👋 @twstokes , looks like all feedback has been addressed in this PR and the WP app PRs also got a green light from reviewers so, wdyt about resuming the merge domino? First step in that direction would be to update this PR to point to Gutenberg's PR and the merged (or later) commit. Then we'll smoke test the main app PRs to avoid having something obvious regressed and merge the gb-mobile PR. We'll need to tag the merged gb-mobile state with an -alpha tag to update in the main apps. Let me know if you need me to elaborate on any of that, thanks!

Thanks @hypest! I believe all of that is clear to me - I appreciate the instructions!

Loading

twstokes added 2 commits Sep 30, 2021
@twstokes
Remove extra strings from bundle generation.
ca67158
@twstokes
Update release notes.
b53d59b
@twstokes twstokes merged commit 95ec33f into develop Sep 30, 2021
12 checks passed
Loading
@twstokes twstokes deleted the try/launch-support-from-inside-editor-2 branch Sep 30, 2021
@guarani guarani mentioned this pull request Oct 1, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment