Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Data: Merge merged edits with the edited record value instead of the persisted one. #17455

Merged
merged 1 commit into from Sep 16, 2019
Merged

Core Data: Merge merged edits with the edited record value instead of the persisted one. #17455

merged 1 commit into from Sep 16, 2019

Conversation

epiqueras
Copy link
Contributor

Fixes #17384

Types of Changes

Bug Fix: Fixed an issue where editing a meta attribute would clear edits to other meta attributes.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@epiqueras epiqueras added [Type] Bug An existing feature is broken. [Package] Core data /packages/core-data labels Sep 16, 2019
@epiqueras epiqueras added this to the Future milestone Sep 16, 2019
@epiqueras epiqueras self-assigned this Sep 16, 2019
youknowriad
youknowriad approved these changes Sep 16, 2019
View changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@youknowriad youknowriad merged commit 66d0ed9 into master Sep 16, 2019
@youknowriad youknowriad deleted the fix/core-data-merged-edits branch September 16, 2019 16:45
dd32 pushed a commit to dd32/gutenberg that referenced this pull request Sep 27, 2019
@epiqueras @youknowriad
Core Data: Merge merged edits with the edited record value instead of…
5c54edb 
… the persisted one. (WordPress#17455)
@karmatosed karmatosed added this to Inbox in Tightening Up Oct 21, 2019
@karmatosed karmatosed removed this from Inbox in Tightening Up Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad

@nerrad nerrad

Assignees

@epiqueras epiqueras

Labels
[Package] Core data /packages/core-data [Type] Bug An existing feature is broken.
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.

SetAttributes does not work as expected with two or more post meta fields
2 participants
@epiqueras @youknowriad