Removes the inspector controls for the navigation block #18948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
getdave
approved these changes
Dec 6, 2019
I tested this and I can confirm the controls have been removed.
I agree that they are not required as they don't really do anything.
|
Looks good to me too. Tests are failing due to some linting errors though, but I can't actually see those errors when I check out the code |
|
Lemme try a rebase. edit: Looks like the attribute declarations were missed, so just removing those. |
|
Rebased and the new alignments code in the nav block uses |
talldan
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
There currently are no sidebar options for the Navigation Block but there is one option who just remained there from the initial testing: automatically add new pages to the menu. This option does nothing if set.
How has this been tested?
The option is gone.