Fix alignment of date picker days when used in block #18856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
requested review from
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
talldan and
youknowriad
as code owners
|
I am sure there is probably a more generic way to fix these layout errors caused by inheritance of |
jasmussen
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Currently if the date picker component is used within a block the day header is misaligned due to inherited editor styles. This PR applies specific margin and padding styles at a higher specificity to prevent this overriding.
How has this been tested?
Tested visually
Screenshots
Before:
After:
Types of changes
CSS only change
Fixes #17129