[Tiny PR] Verse: save line breaks as characters #18372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
jorgefilipecosta,
nerrad,
ntwb,
Soean and
talldan
as code owners
ellatrix
reviewed
Nov 7, 2019
|
Needs rebase. :) |
|
Rebased. :) |
mcsf
reviewed
Nov 21, 2019
mcsf
requested changes
Nov 21, 2019
Hm, the changes are interfering with block merges. In the following comparison, I just press Backspace in an empty Paragraph below a Verse:
<br>-separated |
\n-separated |
|---|---|
 |
 |
ellatrix
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
Same as #14653, but for verse.
Related: #18099.
Fixes #18364.
This should be the behaviour when using
pre, which makes me wonder if we should build it inRichTextif thetagNameis set topre. Thoughts? I do like to keep complexity out ofRichText, but maybe it just makes more sense.How has this been tested?
Screenshots
Types of changes
Checklist: