eslint-plugin: Include WordPress plugin in React ruleset #18457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
aduth
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17635
This pull request resolves an issue where using the React ruleset may cause an error, since the configured rules references a custom WordPress rule, without also including the plugin in the
pluginsarray. Any reference to our custom rules in rulesets must also includeplugins: [ '@wordpress' ], for when those rulesets are used in isolation.See
custom.js:gutenberg/packages/eslint-plugin/configs/custom.js
Lines 2 to 4 in 2102309
Testing Instructions:
Repeat steps to reproduce from #17635, verifying that no error occurs.