Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden nested images in content column #18347

Merged
merged 5 commits into from
Nov 12, 2019
Merged

Fix hidden nested images in content column #18347

merged 5 commits into from
Nov 12, 2019

Conversation

CreativeDive
Copy link
Contributor

@CreativeDive CreativeDive commented Nov 6, 2019

Media/Text block bug with nested Image block: Image is not visible

closes #18296

Left aligned blocks should not inherited "float:left" to nested blocks.

In reference to #17793
Media/Text block bug with nested Image block: Image is not visible #18296
Media/Text block bug with nested Image block: Image is not visible #18296
Fix hidden nested images in content column
@youknowriad youknowriad added [Block] Media & Text Affects the Media & Text Block [Type] Bug An existing feature does not function as intended labels Nov 12, 2019
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks

@CreativeDive
Copy link
Contributor Author

👍 Thanks

Thank you for helping. A question for the future. How I can sync my fork with the current gutenberg master, before I edit code for the PR?

@youknowriad
Copy link
Contributor

@CreativeDive This page might help https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

If you're still having trouble, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Media & Text Affects the Media & Text Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media/Text block bug with nested Image block: Image is not visible
2 participants