Fix Site Tagline block's text alignment #26191
Conversation
Size Change: +3.5 kB (0%) Total Size: 1.19 MB
|
Filename | Size | Change | |
---|---|---|---|
build/a11y/index.js |
1.14 kB | 0 B | |
build/api-fetch/index.js |
3.35 kB | 0 B | |
build/blob/index.js |
668 B | 0 B | |
build/block-directory/style-rtl.css |
943 B | 0 B | |
build/block-directory/style.css |
942 B | 0 B | |
build/block-editor/style-rtl.css |
11 kB | 0 B | |
build/block-editor/style.css |
10.9 kB | 0 B | |
build/block-library/style-rtl.css |
7.71 kB | 0 B | |
build/block-library/style.css |
7.71 kB | 0 B | |
build/block-library/theme-rtl.css |
741 B | 0 B | |
build/block-library/theme.css |
741 B | 0 B | |
build/block-serialization-default-parser/index.js |
1.77 kB | 0 B | |
build/block-serialization-spec-parser/index.js |
3.1 kB | 0 B | |
build/deprecated/index.js |
772 B | 0 B | |
build/dom-ready/index.js |
569 B | 0 B | |
build/dom/index.js |
4.43 kB | 0 B | |
build/edit-navigation/index.js |
10.6 kB | 0 B | |
build/edit-navigation/style-rtl.css |
868 B | 0 B | |
build/edit-navigation/style.css |
871 B | 0 B | |
build/edit-post/style-rtl.css |
6.37 kB | 0 B | |
build/edit-post/style.css |
6.35 kB | 0 B | |
build/edit-site/index.js |
21.6 kB | 0 B | |
build/edit-site/style-rtl.css |
3.8 kB | 0 B | |
build/edit-site/style.css |
3.81 kB | 0 B | |
build/edit-widgets/style-rtl.css |
3.09 kB | 0 B | |
build/edit-widgets/style.css |
3.09 kB | 0 B | |
build/editor/editor-styles-rtl.css |
480 B | 0 B | |
build/editor/editor-styles.css |
482 B | 0 B | |
build/editor/style-rtl.css |
3.85 kB | 0 B | |
build/editor/style.css |
3.84 kB | 0 B | |
build/escape-html/index.js |
733 B | 0 B | |
build/format-library/index.js |
7.49 kB | 0 B | |
build/format-library/style-rtl.css |
547 B | 0 B | |
build/format-library/style.css |
548 B | 0 B | |
build/hooks/index.js |
1.74 kB | 0 B | |
build/html-entities/index.js |
622 B | 0 B | |
build/i18n/index.js |
3.54 kB | 0 B | |
build/is-shallow-equal/index.js |
709 B | 0 B | |
build/keycodes/index.js |
1.85 kB | 0 B | |
build/list-reusable-blocks/index.js |
3.02 kB | 0 B | |
build/list-reusable-blocks/style-rtl.css |
476 B | 0 B | |
build/list-reusable-blocks/style.css |
476 B | 0 B | |
build/media-utils/index.js |
5.12 kB | 0 B | |
build/nux/index.js |
3.27 kB | 0 B | |
build/nux/style-rtl.css |
671 B | 0 B | |
build/nux/style.css |
668 B | 0 B | |
build/primitives/index.js |
1.35 kB | 0 B | |
build/priority-queue/index.js |
789 B | 0 B | |
build/rich-text/index.js |
13 kB | 0 B | |
build/shortcode/index.js |
1.7 kB | 0 B | |
build/viewport/index.js |
1.75 kB | 0 B | |
build/warning/index.js |
1.13 kB | 0 B | |
build/wordcount/index.js |
1.17 kB | 0 B |
Copy appears unchanged from current. I wouldn't recommend changes without more context or review at all copy on the screen (or in Site profile section) as a whole |
Hi. Can you further explain? Which copy, and unchanged from which current? |
Below is what I see in production. The description copy for Site tagline is the same as what is up for review here, as far as I can tell. Forgive me if I'm missing something. I'm responding to the "needs copy review" tag and dropping into this without much context. The copy is fine for the goal of this PR, but if you want to focus on improving it I would suggest looking at all copy in that section as a whole. |
Exactly.
It wasn't the goal to create a new one, but wanted to be sure that it's okay. Thanks for taking the time looking at this @obi2020 ! |
Thanks for clarifying, @obi2020. That screenshot, however, is from Calypso (the project name for the dashboard used specifically in WordPress.com) and not Gutenberg (the block editor available as a plugin, used in WordPress core and WordPress.com alike). What this pull request did was adding a description for the Site Tagline block, which will be displayed inside Gutenberg, and not the Site Tagline setting field in Calypso. Indeed, we reused the description that you were already familiar with in a different interface. |
@mcsf thanks for the notes. I think in this case it's okay to proceed with the copy as is. If you want to prioritize improving it, it would be great to have more context, like screenshots. Ideally, impactful copy decisions happen in the design phase |
Agreed, and duly noted. Thanks for that! |
I've attached a screenshot to the PR description, for future reference. |
ntsekouras commentedOct 16, 2020
•
edited by mcsf
Description
This PR fixes
Site Tagline
block's text alignment. It also adds a small description to the block.Checklist: