Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Site Tagline block's text alignment #26191

Merged
merged 2 commits into from Oct 19, 2020
Merged

Conversation

@ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Oct 16, 2020

Description

This PR fixes Site Tagline block's text alignment. It also adds a small description to the block.

Captura de ecrã 2020-10-20, às 16 57 56

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
@github-actions
Copy link

@github-actions github-actions bot commented Oct 16, 2020

Size Change: +3.5 kB (0%)

Total Size: 1.19 MB

Filename Size Change
build/annotations/index.js 3.54 kB -1 B
build/autop/index.js 2.72 kB +1 B
build/block-directory/index.js 8.61 kB +2 B (0%)
build/block-editor/index.js 130 kB +71 B (0%)
build/block-library/editor-rtl.css 8.93 kB +283 B (3%)
build/block-library/editor.css 8.93 kB +284 B (3%)
build/block-library/index.js 144 kB +1.56 kB (1%)
build/blocks/index.js 47.6 kB +30 B (0%)
build/components/index.js 170 kB +640 B (0%)
build/components/style-rtl.css 15.4 kB -64 B (0%)
build/components/style.css 15.4 kB -65 B (0%)
build/compose/index.js 9.63 kB +1 B
build/core-data/index.js 12.1 kB +1 B
build/data-controls/index.js 683 B -1 B
build/data/index.js 8.63 kB -2 B (0%)
build/date/index.js 31.9 kB +1 B
build/edit-post/index.js 306 kB -5 B (0%)
build/edit-widgets/index.js 22.3 kB +743 B (3%)
build/editor/index.js 42.6 kB +9 B (0%)
build/element/index.js 4.45 kB -2 B (0%)
build/keyboard-shortcuts/index.js 2.38 kB -1 B
build/notices/index.js 1.69 kB -1 B
build/plugins/index.js 2.44 kB -1 B
build/redux-routine/index.js 2.85 kB -2 B (0%)
build/reusable-blocks/index.js 3.06 kB +23 B (0%)
build/server-side-render/index.js 2.61 kB +2 B (0%)
build/token-list/index.js 1.24 kB -1 B
build/url/index.js 4.06 kB -6 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/blob/index.js 668 B 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 11 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/style-rtl.css 7.71 kB 0 B
build/block-library/style.css 7.71 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.77 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 4.43 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/style-rtl.css 6.37 kB 0 B
build/edit-post/style.css 6.35 kB 0 B
build/edit-site/index.js 21.6 kB 0 B
build/edit-site/style-rtl.css 3.8 kB 0 B
build/edit-site/style.css 3.81 kB 0 B
build/edit-widgets/style-rtl.css 3.09 kB 0 B
build/edit-widgets/style.css 3.09 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/primitives/index.js 1.35 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/rich-text/index.js 13 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/viewport/index.js 1.75 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@ntsekouras ntsekouras merged commit f8e10e0 into master Oct 19, 2020
15 checks passed
15 checks passed
@github-actions
Cancel Previous Runs Cancel Previous Runs
Details
@github-actions
Check Check
Details
@github-actions
build
Details
@github-actions
Admin - 1
Details
@github-actions
Compare performance with master
Details
@github-actions
pull-request-automation
Details
@github-actions
test (gutenberg-editor-gallery)
Details
@github-actions
test (gutenberg-editor-gallery)
Details
@github-actions
JavaScript
Details
@github-actions
Admin - 2
Details
@github-actions
Admin - 3
Details
@github-actions
Mobile
Details
@github-actions
Admin - 4
Details
@ntsekouras ntsekouras deleted the fix/tagline-text-alignment branch Oct 19, 2020
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 19, 2020
Copy link

@obi2020 obi2020 left a comment

Copy appears unchanged from current. I wouldn't recommend changes without more context or review at all copy on the screen (or in Site profile section) as a whole

@mcsf
Copy link
Contributor

@mcsf mcsf commented Oct 19, 2020

Copy appears unchanged from current.

Hi. Can you further explain? Which copy, and unchanged from which current?

@obi2020
Copy link

@obi2020 obi2020 commented Oct 19, 2020

Below is what I see in production. The description copy for Site tagline is the same as what is up for review here, as far as I can tell.

site tagline desc

Forgive me if I'm missing something. I'm responding to the "needs copy review" tag and dropping into this without much context. The copy is fine for the goal of this PR, but if you want to focus on improving it I would suggest looking at all copy in that section as a whole.

@ntsekouras
Copy link
Contributor Author

@ntsekouras ntsekouras commented Oct 20, 2020

The description copy for Site tagline is the same as what is up for review here, as far as I can tell.

Exactly.

The copy is fine for the goal of this PR, but if you want to focus on improving it I would suggest looking at all copy in that section as a whole.

It wasn't the goal to create a new one, but wanted to be sure that it's okay. Thanks for taking the time looking at this @obi2020 !

@mcsf
Copy link
Contributor

@mcsf mcsf commented Oct 20, 2020

Thanks for clarifying, @obi2020. That screenshot, however, is from Calypso (the project name for the dashboard used specifically in WordPress.com) and not Gutenberg (the block editor available as a plugin, used in WordPress core and WordPress.com alike).

What this pull request did was adding a description for the Site Tagline block, which will be displayed inside Gutenberg, and not the Site Tagline setting field in Calypso. Indeed, we reused the description that you were already familiar with in a different interface.

@obi2020
Copy link

@obi2020 obi2020 commented Oct 20, 2020

@mcsf thanks for the notes. I think in this case it's okay to proceed with the copy as is. If you want to prioritize improving it, it would be great to have more context, like screenshots. Ideally, impactful copy decisions happen in the design phase

@mcsf
Copy link
Contributor

@mcsf mcsf commented Oct 20, 2020

Agreed, and duly noted. Thanks for that!

@mcsf
Copy link
Contributor

@mcsf mcsf commented Oct 20, 2020

would be great to have more context, like screenshots

I've attached a screenshot to the PR description, for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants