Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect attribute type specified in Search block #25813

Merged
merged 1 commit into from Oct 5, 2020
Merged

Fix incorrect attribute type specified in Search block #25813

merged 1 commit into from Oct 5, 2020
+2 −2

Conversation

@bobbingwide
Copy link
Contributor

@bobbingwide bobbingwide commented Oct 4, 2020

Avoid Notice: rest_validate_value_from_schema
Change the type for showLabel and buttonUseIcon from "bool" to "boolean" to avoid notices when WP_DEBUG is true.

Description

I've corrected the values to avoid Notices from rest_validate_value_from_schema

How has this been tested?

In a local development environment. After applying the change I edited and viewed the Search block I'd created earlier. The Notices were no longer displayed.

Screenshots

image

Types of changes

Typo fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
@bobbingwide
Fixes #25812 - Correct bool to boolean to avoid Notices
31401ee 
Avoid Notice: rest_validate_value_from_schema
@bobbingwide bobbingwide requested review from ajitbohra, Soean and talldan as code owners Oct 4, 2020
@talldan talldan linked an issue that may be closed by this pull request Oct 5, 2020
Definition of showLabel and buttonUseIcon in the search block's block.json should be "boolean" not "bool" #25812
Closed
@talldan
talldan approved these changes Oct 5, 2020
View changes
Copy link
Contributor

@talldan talldan left a comment

Thanks @bobbingwide. Appreciate the upstream fix to attribute validation as well.
@talldan talldan merged commit 654f7cb into WordPress:master Oct 5, 2020
15 checks passed
15 checks passed
@github-actions
Cancel Previous Runs
Details
@github-actions
Check Check
Details
@github-actions
build
Details
@github-actions
Admin - 1
Details
@github-actions
Compare performance with master
Details
@github-actions
pull-request-automation
Details
@github-actions
test (gutenberg-editor-gallery)
Details
@github-actions
test (gutenberg-editor-gallery)
Details
@github-actions
All
Details
@github-actions
JavaScript
Details
@github-actions
Admin - 2
Details
@github-actions
PHP
Details
@github-actions
Admin - 3
Details
@github-actions
Mobile
Details
@github-actions
Admin - 4
Details
@talldan talldan changed the title Fixes #25812 - Correct bool to boolean to avoid Notices Fix incorrect attribute type specified in Search block Oct 5, 2020
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 5, 2020
kevin940726 added a commit that referenced this pull request Oct 6, 2020
@bobbingwide @kevin940726
Fixes #25812 - Correct bool to boolean to avoid Notices (#25813)
383fd35 
Avoid Notice: rest_validate_value_from_schema
kevin940726 added a commit that referenced this pull request Oct 6, 2020
@bobbingwide @kevin940726
Fixes #25812 - Correct bool to boolean to avoid Notices (#25813)
861fadf 
Avoid Notice: rest_validate_value_from_schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan

@ajitbohra ajitbohra

@Soean Soean

Assignees
No one assigned
Labels
[Block] Search [Type] Bug
Projects
None yet
Milestone
Gutenberg 9.2
Linked issues

Successfully merging this pull request may close these issues.

Definition of showLabel and buttonUseIcon in the search block's block.json should be "boolean" not "bool"
2 participants
@bobbingwide @talldan