Size Change: +121 B (0%)

Total Size: 1.18 MB

_{compressed-size-action}

Looks good! The block is inserted into the right place when I click on it in the inserter.

This isn't addressing the first part of #25708, though. When I hover over the block in the inserter, I should see a blue line appear at the bottom of the widget area where the block will be inserted.

When I hover over the block in the inserter, I should see a blue line appear at the bottom of the widget area where the block will be inserted.

@noisysocks Good point, I missed it! However, there's no blue line when inserting to post editor via the inserter either though. I wonder if we should follow the current behavior in post editor? 🤔

When I hover over the block in the inserter, I should see a blue line appear at the bottom of the widget area where the block will be inserted.

@noisysocks Good point, I missed it! However, there's no blue line when inserting to post editor via the inserter either though. I wonder if we should follow the current behavior in post editor? 🤔

Oh, huh. That might be a bug unless it was intentionally removed and @mapk and I have missed it.

It seems like in both the post editor and widgets editor the blue line doesn't show if you're trying to insert at the end of a block list.

I think it's only implemented to show before a block that exists:
https://github.com/WordPress/gutenberg/blob/master/packages/block-editor/src/components/block-list/insertion-point.js#L110

I made a separate bug report for this - #25785

@kevin940726 this looks great overall! I found two problems:

1. If I select a block, click on the empty space (grey area), and open the inserter after that - the insertion point resets to the end of the widget area.
2. There is no margin between the legacy widget and the insertion point. We could fix it in a follow-up PR as it seems to be more related to the way legacy-widget block is styled, but we should keep track of it:

I encouraged the same interaction as in the post editor here. If there is an area selected, or a block selected that has no blocks below it, the blue line doesn't appear. I could be convinced that it needs to show all the time.

If I select a block, click on the empty space (grey area), and open the inserter after that - the insertion point resets to the end of the widget area.

@adamziel This seems expected to me? Since the user explicitly "un-focus" the selected block. I think it could be pretty frustrating if the user can't do that. It's just my opinion though, and I would love to be proven wrong!

There is no margin between the legacy widget and the insertion point. We could fix it in a follow-up PR as it seems to be more related to the way legacy-widget block is styled, but we should keep track of it:

Nice catch! Open another issue?

@kevin940726 yes, can you open another issue for that lack of margin?

@adamziel This seems expected to me? Since the user explicitly "un-focus" the selected block. I think it could be pretty frustrating if the user can't do that. It's just my opinion though, and I would love to be proven wrong!

@kevin940726 I checked what happens in the post editor. If you click on the top bar, it still remembers the last focused block.

I checked what happens in the post editor. If you click on the top bar, it still remembers the last focused block.

Hmmm, interesting, could you share a gif just to be sure that I understand it correctly?

It's similar in the Widgets Editor, it will remember the last focused block if you click on the top bar. In the post editor, the inserter will append to the end when you click on an empty area in the post too. I think they are behaving similarly? Maybe I'm missing some edge cases though 🤔 .

yes, can you open another issue for that lack of margin?

@mapk Sure! Opened #25848.

@kevin940726 oh that's right! It seems like it's a mental model thing - in the post editor, the entire page is the editor and so whenever I want to remove the blue focus I feel it's "safe" to click on the blank area of top bar without really affecting the editor area (as if the top bar was outside of the editor). I applied the same mental model to the grey area in the widgets editor, even though if you inspect it with dev tools, it is part of the editor. I somehow instinctively click there every now and then though (as if it was outside of the editor) :-)

Sounds like it's something that we should consider separately (if at all). Let me CC @mapk and approve this PR!