stage2: implement ** and ++ at runtime #9876
Conversation
g-w1
changed the title
|
I stubbed the case that causes the uaf out as a TODO for now as it is confusing me. |
|
Thanks for fixing the uaf! |
g-w1
force-pushed
the
runn
branch
3 times, most recently
from
97641f8
to
71c902b
Compare
src/Sema.zig
Outdated
| const alloc = try block.addTy(.alloc, ptr_ty); | ||
|
|
||
| try sema.requireRuntimeBlock(block, lhs_src); | ||
| if (mulinfo.len * mulinfo.elem_type.abiSize(sema.mod.getTarget()) <= 65535) { // if its less than the max integer size, we can bitcast it to an int |
There was a problem hiding this comment.
This logic has to do with the limitations of the LLVM backend, specifically, right?
The AIR memset instruction is perfectly capable of representing any sized element. The LLVM backend can do this logic of checking for 65535, and the other backends can choose a different strategy for lowering the AIR instruction.
There was a problem hiding this comment.
Well, the zig language requires that ints have bits <= 65535, so it may be because of llvm, but llvm is not the only reason, it's the zig spec.
There was a problem hiding this comment.
Why integers? The element type of an array could be many other types besides integers
ptr_elem_ptr is a ty_pl, not bin_op also use usize instead of u64
|
Ok, marking as draft as memset with bitcast is being weird in llvm backend. |
|
30+ days old draft; closing. |
No description provided.