Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest better place to add call parentheses for method expressions wrapped in parentheses #89055

Merged
merged 1 commit into from Sep 19, 2021

Conversation

@Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Sep 17, 2021

I wanted to improve the suggestion a bit to both remove the wrapping parentheses and add call parentheses by both calling suggest_method_call and using multipart_suggestion. But I very quickly ran into a problem where multiple overlapping machine applicable suggestions cannot be properly applied together. So I applied the suggestion from the issue and only added the call parentheses directly after the expression.

Fixes: #89044

@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented Sep 17, 2021

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-log-analyzer

This comment has been hidden.

@Kobzol Kobzol force-pushed the wrapped-method-expr-call-parens branch from 9f6c836 to 68147eb Sep 18, 2021
Copy link
Member

@wesleywiser wesleywiser left a comment

Awesome! 👍

@wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented Sep 18, 2021

@bors r+ rollup

@bors
Copy link
Contributor

@bors bors commented Sep 18, 2021

📌 Commit 68147eb has been approved by wesleywiser

JohnTitor added a commit to JohnTitor/rust that referenced this issue Sep 19, 2021
…ens, r=wesleywiser

Suggest better place to add call parentheses for method expressions wrapped in parentheses

I wanted to improve the suggestion a bit to both remove the wrapping parentheses **and** add call parentheses by both calling `suggest_method_call` and using `multipart_suggestion`. But I very quickly ran into a problem where multiple overlapping machine applicable suggestions cannot be properly applied together. So I applied the suggestion from the issue and only added the call parentheses directly after the expression.

Fixes: rust-lang#89044
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 19, 2021
Rollup of 11 pull requests

Successful merges:

 - rust-lang#87960 (Suggest replacing an inexisting field for an unmentioned field)
 - rust-lang#88855 (Allow simd_shuffle to accept vectors of any length)
 - rust-lang#88966 (Check for shadowing issues involving block labels)
 - rust-lang#88996 (Fix linting when trailing macro expands to a trailing semi)
 - rust-lang#89017 (fix potential race in AtomicU64 time monotonizer)
 - rust-lang#89021 (Add a separate error for `dyn Trait` in `const fn`)
 - rust-lang#89023 (Resolve issue 85066)
 - rust-lang#89051 (Add intra-doc links and small changes to `std::os` to be more consistent)
 - rust-lang#89053 (refactor: VecDeques IntoIter fields to private)
 - rust-lang#89055 (Suggest better place to add call parentheses for method expressions wrapped in parentheses)
 - rust-lang#89081 (Fix a typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 19, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#87960 (Suggest replacing an inexisting field for an unmentioned field)
 - rust-lang#88855 (Allow simd_shuffle to accept vectors of any length)
 - rust-lang#88966 (Check for shadowing issues involving block labels)
 - rust-lang#88996 (Fix linting when trailing macro expands to a trailing semi)
 - rust-lang#89017 (fix potential race in AtomicU64 time monotonizer)
 - rust-lang#89021 (Add a separate error for `dyn Trait` in `const fn`)
 - rust-lang#89051 (Add intra-doc links and small changes to `std::os` to be more consistent)
 - rust-lang#89053 (refactor: VecDeques IntoIter fields to private)
 - rust-lang#89055 (Suggest better place to add call parentheses for method expressions wrapped in parentheses)
 - rust-lang#89081 (Fix a typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 441046a into rust-lang:master Sep 19, 2021
10 checks passed
@rustbot rustbot added this to the 1.57.0 milestone Sep 19, 2021
@Kobzol Kobzol deleted the wrapped-method-expr-call-parens branch Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants