Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect bare blocks with type ascription that were meant to be a struct literal #88598

Merged
merged 1 commit into from Sep 4, 2021
Merged

Detect bare blocks with type ascription that were meant to be a struct literal #88598

merged 1 commit into from Sep 4, 2021

Conversation

@estebank
Copy link
Contributor

@estebank estebank commented Sep 2, 2021

Address part of #34255.

Potential improvement: silence the other knock down errors in issue-34255-1.rs.
@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented Sep 2, 2021

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@estebank
Copy link
Contributor Author

@estebank estebank commented Sep 2, 2021

@bors try @rust-timer queue

@rust-timer

This comment has been hidden.

Sign in to view
@bors

This comment has been hidden.

Sign in to view
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 2, 2021
@bors
Auto merge of rust-lang#88598 - estebank:type-ascription-can-die-in-a…
c2d9a93 
…-fire, r=<try>

Detect bare blocks with type ascription that were meant to be a `struct` literal

Address part of rust-lang#34255.

Potential improvement: silence the other knock down errors in `issue-34255-1.rs`.
@rust-log-analyzer

This comment has been hidden.

Sign in to view
@estebank estebank force-pushed the type-ascription-can-die-in-a-fire branch from 07a7d72 to 9781a0a Sep 2, 2021
@estebank

This comment has been hidden.

Sign in to view
@rust-timer

This comment has been hidden.

Sign in to view
@bors

This comment has been hidden.

Sign in to view
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 2, 2021
@bors
Auto merge of rust-lang#88598 - estebank:type-ascription-can-die-in-a…
f35a12f 
…-fire, r=<try>

Detect bare blocks with type ascription that were meant to be a `struct` literal

Address part of rust-lang#34255.

Potential improvement: silence the other knock down errors in `issue-34255-1.rs`.
@rust-log-analyzer

This comment has been hidden.

Sign in to view
@rust-log-analyzer

This comment has been hidden.

Sign in to view
@bors

This comment has been hidden.

Sign in to view
@rust-timer
Copy link
Collaborator

@rust-timer rust-timer commented Sep 2, 2021

Queued f35a12f with parent 1cf8fdd, future comparison URL.

@rust-timer
Copy link
Collaborator

@rust-timer rust-timer commented Sep 3, 2021

Finished benchmarking try commit (f35a12f): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@estebank estebank force-pushed the type-ascription-can-die-in-a-fire branch from 9781a0a to 6d45a1a Sep 3, 2021
@estebank
Detect bare blocks with type ascription that were meant to be a `stru…
12ce6e9 
…ct` literal

Address part of rust-lang#34255.

Potential improvement: silence the other knock down errors in
`issue-34255-1.rs`.
@estebank estebank force-pushed the type-ascription-can-die-in-a-fire branch from 6d45a1a to 12ce6e9 Sep 3, 2021
wesleywiser
wesleywiser approved these changes Sep 3, 2021
View changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Nice!

@wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented Sep 3, 2021

@bors r+

@bors
Copy link
Contributor

@bors bors commented Sep 3, 2021

📌 Commit 12ce6e9 has been approved by wesleywiser

@bors
Copy link
Contributor

@bors bors commented Sep 4, 2021

⌛ Testing commit 12ce6e9 with merge b4e8596...

@bors
Copy link
Contributor

@bors bors commented Sep 4, 2021

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing b4e8596 to master...

@bors bors merged commit b4e8596 into rust-lang:master Sep 4, 2021
11 checks passed
@rustbot rustbot added this to the 1.56.0 milestone Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser

Assignees

@wesleywiser wesleywiser

Labels
merged-by-bors S-waiting-on-bors
Projects
None yet
Milestone
1.56.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@estebank @rust-highfive @rust-timer @bors @rust-log-analyzer @wesleywiser @rustbot