New lint: same_name_method
#7653
Conversation
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
11f6fb7
to
c81cd9a
adceb5f
to
9e3ff2a
Apart from making this a |
Thx! I have removed the todos. |
What's your take on restriction vs. pedantic? Why would you not be satisfied with the former? |
I have no deep insight into the category of lint. Please help we with this hard decision ! |
The idea behind As I don't see how your lints could have false positives, yet depending on the context people may choose to ignore it, this fits the |
I agree on |
r=me with the changed lint category |
Thank you @lengyijun ! @bors r+ |
|
|
lengyijun commentedSep 10, 2021
•
edited
changelog:
[`same_name_method`]
fix: #7632
It only compares a method in
impl
with another inimpl trait for
It doesn't lint two methods in two traits.
I'm not sure my approach is the best way. I meet difficulty in other approaches.
The text was updated successfully, but these errors were encountered: