Pinned
3,043 contributions in the last year
Less
More
Activity overview
Contribution activity
August 2021
Created 64 commits in 4 repositories
Created a pull request in rust-lang/rust that received 16 comments
Remove size_of == 1 case from fill
specialization.
Fixes #87891 See discussion on Zulip.
+2
−14
•
16
comments
Opened 27 other pull requests in 3 repositories
rust-lang/rust
7
open
17
merged
1
closed
- Don't suggest extra <> in dyn suggestion.
- Keep turbofish in prelude collision lint.
- Warn when [T; N].into_iter() is ambiguous in the new edition.
- Use right span in prelude collision suggestions with macros.
- Fix prelude collision suggestions for glob imported traits.
- Fix prelude collision lint suggestion for generics with lifetimes
- Rollup of 6 pull requests
- Stop tracking namespace in used_imports.
- Add notes to macro-not-found diagnostics to point out how things with the same name were not a match.
- Suggest importing the right kind of macro.
- Rollup of 10 pull requests
- Rollup of 7 pull requests
- Improve non_fmt_panics suggestion based on trait impls.
- Closure lint wording
- Add automatic migration for assert!(.., string).
- Include attributes in removal span for unused imports.
- Detect fake spans in non_fmt_panic lint.
- Silence non_fmt_panic from external macros.
- Closure migration multispan suggestions
- Fix closure migration suggestion when the body is a macro.
- Improve formatting of closure capture migration suggestion for multi-line closures.
- Link to edition guide instead of issues for 2021 lints.
- Alloc features cleanup
- Core features cleanup
- Re-use std::sealed::Sealed in os/linux/process.
rust-lang/stdarch
1
merged
rust-lang/highfive
1
merged
Reviewed 12 pull requests in 3 repositories
rust-lang/rust
10 pull requests
- Fix prelude collision lint suggestion for generics with lifetimes
- Stabilize try_reserve
- Add notes to macro-not-found diagnostics to point out how things with the same name were not a match.
- Account for tabs when highlighting multiline code suggestions
- Suggest importing the right kind of macro.
- Improve non_fmt_panics suggestion based on trait impls.
- Fix closure migration suggestion when the body is a macro.
- Fix Windows Command::env("PATH")
- Weaken guarantee around advancing underlying iterators in zip
- I/O safety.
rust-lang/libs-team
1 pull request
rust-lang/rfcs
1 pull request
Created an issue in rust-lang/rust that received 17 comments
Wrong part colored in diagnostic suggestions after tabs
trait T { const A: &u8;
}
(The second line starts with a tab, not with spaces!)
This results in:
It suggests to add a 'a
after the &
, but the gre…
17
comments
Opened 14 other issues in 2 repositories
rust-lang/rust
7
open
6
closed
- Invalid suggestion to change <Trait>::.. to <<dyn Trait>>::..:
- Missing derive macro suggests importing regular macro
- Confusing diagnostics on #[derive(X)] when X is imported only as trait
- non_fmt_panics suggestion applied many times when it appears inside a macro_rules
- closure capture migrations do not note when move is now required
-
Invalid
dyn
suggestions - non_panic_fmt lint suggestion should check what traits are implemented
- Stabilize Rust 2021
- rust_2021_incompatible_closure_captures suggestion expands macro
- rust_2021_incompatible_closure_captures lint produces bad formatting
-
Undefined behaviour in
slice::fill
specialization. - Tracking issue for organizing the standard library's #![feature]s
- Update array and iterator docs in std / core for new IntoIterator impl and edition.
rust-lang/cargo
1
open
82
contributions
in private repositories
Aug 1 – Aug 22