Skip to content

/ synth Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unbounded numbers #145

Open
llogiq opened this issue Sep 14, 2021 · 1 comment · May be fixed by #146
Open

Allow unbounded numbers #145

llogiq opened this issue Sep 14, 2021 · 1 comment · May be fixed by #146
Labels
core enhancement good first issue help wanted

Comments

@llogiq
Copy link
Member

@llogiq llogiq commented Sep 14, 2021 •
edited

Required Functionality
Currently number types can only be range, categorical (for integers) and constant (also some can be Id). There is no easy way to specify generating arbitrary numbers

Proposed Solution
Consider adding an unbounded variant that will generate any valid number of the given type, alternatively make serde use the range default if no argument at all is given.

Use case
Simplify the default, allow getting arbitrary numbers without much hassle
@brokad brokad linked a pull request that will close this issue Sep 14, 2021
Draft
3 tasks
@brokad
Copy link
Contributor

@brokad brokad commented Sep 14, 2021

Great idea @llogiq! As a matter of fact, from discussions we had, I think we can kill two birds with one stone with #146. Let me know what you think and if it does indeed address this along the lines of your second proposed solution (the default one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix: number nodes import and schema serde issues
2 participants
@llogiq @brokad