Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aria-expanded from close button in Publish panel #20993

Merged
merged 3 commits into from Mar 19, 2020
Merged

Remove aria-expanded from close button in Publish panel #20993

merged 3 commits into from Mar 19, 2020

Conversation

@enriquesanchez
Copy link
Contributor

@enriquesanchez enriquesanchez commented Mar 18, 2020 •
edited

Fixes #20278

This tiny PR removes the aria-expanded attribute from the Close (X) button in the Publish panel. The attribute is not necessary in this button (the close button hasn't opened a menu) and it was making the button to be displayed in the wrong color.

How has this been tested?

Locally.

Screenshots

Before:
Screen Shot 2020-03-18 at 10 16 22

After:
Screen Shot 2020-03-17 at 18 53 47

Types of changes

HTML and visual.
@enriquesanchez
Remove aria-expanded from close button in Publish panel
fd1ea78
@enriquesanchez enriquesanchez requested review from mapk and jasmussen Mar 18, 2020
@enriquesanchez enriquesanchez self-assigned this Mar 18, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Mar 18, 2020 •
edited

Size Change: +129 B (0%)

Total Size: 857 kB

Filename Size Change
build/block-editor/index.js 100 kB +30 B (0%)
build/block-editor/style-rtl.css 10.9 kB +35 B (0%)
build/block-editor/style.css 10.9 kB +27 B (0%)
build/block-library/editor-rtl.css 7.21 kB -26 B (0%)
build/block-library/editor.css 7.21 kB -26 B (0%)
build/block-library/index.js 111 kB +14 B (0%)
build/components/index.js 191 kB +71 B (0%)
build/edit-widgets/index.js 4.43 kB -1 B
build/editor/index.js 43.8 kB -3 B (0%)
build/editor/style-rtl.css 3.97 kB +2 B (0%)
build/editor/style.css 3.96 kB +3 B (0%)
build/primitives/index.js 1.5 kB +2 B (0%)
build/rich-text/index.js 14.3 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 998 B 0 B
build/annotations/index.js 3.43 kB 0 B
build/api-fetch/index.js 3.39 kB 0 B
build/autop/index.js 2.58 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 6.02 kB 0 B
build/block-directory/style-rtl.css 760 B 0 B
build/block-directory/style.css 760 B 0 B
build/block-library/style-rtl.css 7.42 kB 0 B
build/block-library/style.css 7.43 kB 0 B
build/block-library/theme-rtl.css 669 B 0 B
build/block-library/theme.css 671 B 0 B
build/block-serialization-default-parser/index.js 1.65 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 57.5 kB 0 B
build/components/style-rtl.css 15.7 kB 0 B
build/components/style.css 15.7 kB 0 B
build/compose/index.js 6.21 kB 0 B
build/core-data/index.js 10.6 kB 0 B
build/data-controls/index.js 1.04 kB 0 B
build/data/index.js 8.2 kB 0 B
build/date/index.js 5.37 kB 0 B
build/deprecated/index.js 771 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 3.06 kB 0 B
build/edit-post/index.js 91.2 kB 0 B
build/edit-post/style-rtl.css 8.47 kB 0 B
build/edit-post/style.css 8.46 kB 0 B
build/edit-site/index.js 5.56 kB 0 B
build/edit-site/style-rtl.css 2.62 kB 0 B
build/edit-site/style.css 2.62 kB 0 B
build/edit-widgets/style-rtl.css 2.58 kB 0 B
build/edit-widgets/style.css 2.58 kB 0 B
build/editor/editor-styles-rtl.css 381 B 0 B
build/editor/editor-styles.css 382 B 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 6.95 kB 0 B
build/format-library/style-rtl.css 502 B 0 B
build/format-library/style.css 502 B 0 B
build/hooks/index.js 1.93 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.49 kB 0 B
build/is-shallow-equal/index.js 711 B 0 B
build/keyboard-shortcuts/index.js 2.3 kB 0 B
build/keycodes/index.js 1.69 kB 0 B
build/list-reusable-blocks/index.js 2.99 kB 0 B
build/list-reusable-blocks/style-rtl.css 226 B 0 B
build/list-reusable-blocks/style.css 226 B 0 B
build/media-utils/index.js 4.83 kB 0 B
build/notices/index.js 1.58 kB 0 B
build/nux/index.js 3.01 kB 0 B
build/nux/style-rtl.css 616 B 0 B
build/nux/style.css 613 B 0 B
build/plugins/index.js 2.54 kB 0 B
build/priority-queue/index.js 780 B 0 B
build/redux-routine/index.js 2.83 kB 0 B
build/server-side-render/index.js 2.55 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.01 kB 0 B
build/viewport/index.js 1.61 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.18 kB 0 B

compressed-size-action

@talldan
talldan approved these changes Mar 19, 2020
View changes
Copy link
Contributor

@talldan talldan left a comment

Looks good to me, well spotted! It looks like some snapshots need to be updated, but once that's done I don't see an issue merging.
@jasmussen
Copy link
Contributor

@jasmussen jasmussen commented Mar 19, 2020

I have a small fix I'd like to push to this one. Hold tight for a few minutes as I'm rebuilding my wp env because "don't ask" :)

jasmussen added 2 commits Mar 19, 2020
@jasmussen
Small border fix.
c366599
@jasmussen
Update snapshots.
248d83d
@jasmussen
jasmussen approved these changes Mar 19, 2020
View changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Very nice PR, small and to the point — keep this going! I see this now:

now

This is superb. But I also discovered this:

Screenshot 2020-03-19 at 08 11 06

The border is off by one 😱

So I took the liberty of pushing c366599 to address that. I also updated the snapshots.

Ship it!
@enriquesanchez
Copy link
Contributor Author

@enriquesanchez enriquesanchez commented Mar 19, 2020

Thank you @talldan and @jasmussen! Good catch on that border! 😄

@enriquesanchez enriquesanchez merged commit dcfbd8c into master Mar 19, 2020
3 checks passed
3 checks passed
@github-actions
build
Details
@github-actions
pull-request-automation
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@enriquesanchez enriquesanchez deleted the try/remove-aria-expanded-from-publish-panel-close-button branch Mar 19, 2020
@github-actions github-actions bot added this to the Gutenberg 7.8 milestone Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan

@jasmussen jasmussen

@mapk mapk

Assignees

@enriquesanchez enriquesanchez

Labels
None yet
Projects
None yet
Milestone
Gutenberg 7.8
Linked issues

Successfully merging this pull request may close these issues.

Standarize 'close' icon across the UI
3 participants
@enriquesanchez @jasmussen @talldan