Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer read from experimental-theme.json #33904

Merged
merged 2 commits into from Aug 9, 2021

Conversation

@nosolosw
Copy link
Member

@nosolosw nosolosw commented Aug 5, 2021

We used experimental-theme.json as a name for the file that holds the settings & styles while it was experimental. When the feature was stabilized the file was renamed to theme.json but we also kept a fallback to the previous name in the plugin, so themes had some time to rename it. We can get rid of this fallback now that WordPress 5.8 is released and bundles theme.json by default.

@nosolosw nosolosw requested a review from spacedmonkey as a code owner Aug 5, 2021
@nosolosw nosolosw self-assigned this Aug 5, 2021
@nosolosw nosolosw requested a review from WordPress/gutenberg-core Aug 5, 2021
@nosolosw nosolosw requested a review from aristath Aug 5, 2021
@nosolosw nosolosw changed the title Remove no longer necessary fallback No longer read from experimental-theme.json Aug 5, 2021
@Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Aug 5, 2021

This is probably a task for separated PR. But should we also rename experimental-default-theme.json, that we ship with the plugin, to default-theme.json or theme.json?

@nosolosw
Copy link
Member Author

@nosolosw nosolosw commented Aug 6, 2021

@Mamaduka it makes sense to me, also for the i18n file. Prepared it at #33925

@nosolosw nosolosw requested a review from Mamaduka Aug 6, 2021
Copy link
Member

@Mamaduka Mamaduka left a comment

LGTM 👍

I don't think we need deprecation here since this was an experimental structure/file.

@nosolosw nosolosw force-pushed the remove/experimental-theme-json-fallback branch from 112e35c to 4d1bdb3 Aug 9, 2021
@nosolosw nosolosw merged commit 5acde95 into trunk Aug 9, 2021
19 checks passed
19 checks passed
@github-actions
Compute current and next stable release branches
Details
@github-actions
test
Details
@github-actions
Checks (12)
Details
@github-actions
Admin - 1 Admin - 1
Details
@github-actions
Run performance tests
Details
@github-actions
pull-request-automation (14)
Details
@github-actions
test (12.2, gutenberg-editor-initial-html, 14)
Details
@github-actions
JavaScript (12)
Details
@github-actions
Checks (14)
Details
@github-actions
Admin - 2 Admin - 2
Details
@github-actions
JavaScript (14)
Details
@github-actions
Admin - 3 Admin - 3
Details
@github-actions
Admin - 4 Admin - 4
Details
@github-actions
Bump version
Details
@github-actions
Build Release Artifact
Details
@github-actions
Mobile
Details
@github-actions
Create Release Draft and Attach Asset
Details
@nosolosw nosolosw deleted the remove/experimental-theme-json-fallback branch Aug 9, 2021
@github-actions github-actions bot added this to the Gutenberg 11.3 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants