No longer read from experimental-theme.json
#33904
Merged
Conversation
nosolosw
changed the title
Remove no longer necessary fallback
No longer read from Aug 5, 2021
experimental-theme.json
This is probably a task for separated PR. But should we also rename |
LGTM I don't think we need deprecation here since this was an experimental structure/file. |
nosolosw
force-pushed the
remove/experimental-theme-json-fallback
branch
from
Aug 9, 2021
112e35c
to
4d1bdb3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nosolosw commentedAug 5, 2021
We used
experimental-theme.json
as a name for the file that holds the settings & styles while it was experimental. When the feature was stabilized the file was renamed totheme.json
but we also kept a fallback to the previous name in the plugin, so themes had some time to rename it. We can get rid of this fallback now that WordPress 5.8 is released and bundlestheme.json
by default.