Readable JS assets Plugin: Fix webpack 5 support #33785
Open
+3
−1
Conversation
In webpack v5 `Compilation.chunks` and `Chunk.files` changed from arrays to sets. See https://webpack.js.org/blog/2020-10-10-webpack-5-release/#arrays-to-sets Support both v4 and v5 by making sure we work with arrays (converting the set to array for v5) when generating the files list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
walbo commentedJul 30, 2021
Description
In webpack v5
Compilation.chunks
andChunk.files
changed from arrays to sets. See https://webpack.js.org/blog/2020-10-10-webpack-5-release/#arrays-to-setsSupport both v4 and v5 by making sure we work with arrays (converting the set to array for v5) when generating the files list.
How has this been tested?
Tested the plugin both in webpack v4 and v5.
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).