There's a bug in this function: You can easily see it by checking the "button" block in the "emptytheme". You'll see that the paddings are broken in the frontend.

While we could probably fix this somehow by improving the regex, I wonder if it's actually better to not minify ourselves and instead let the minification tools do the work by:

1- Assuming that the file is already minified (and add it to our setup)
2- Introduce a potential convention: load .min.css if the file is available instead of .css.

I personally lean towards 1 and potentially support for core blocks falling back in the blocks registration to unminified files if SCRIPT_DEBUG is true. (I don't like smart behaviors in general and we should better let the right tools handle the right job :) )

I guess it's fixed by #29554 that said I still think we'd better removing the minification from the framework itself.

Regarding the bug, #29554 was just merged and fixes it.

I agree however that we should provide minified files, the current ones are OK for debugging but on a real production environment, they are wasteful.

@youknowriad do you know how to do that? I remember I tried to do it in #25220 but ran into issues, mostly because I don't quite understand our tooling and how to use it 😅

I think it's all in the stylesTransform function we have in the webpack config which in theory should generate minified styles for production code (npm run build) and unmagnified ones for development ( npm run dev)

Huh... So it already runs as it should, I just always run dev so didn't see that they get minified on production builds 🤦
I'll submit a PR to remove the minify function 👍

At some point in the future, we might want to ship both files at the same time and introduce the SCRIPT_DEBUG flag support but it's not only about these blocks styles, it's about all JS and styles in Gutenberg plugin.

At some point in the future, we might want to ship both files at the same time and introduce the SCRIPT_DEBUG flag support but it's not only about these blocks styles, it's about all JS and styles in Gutenberg plugin.

This is how it works in the WordPress core.

PR submitted on #29624 👍

Related issue about shipping .min.* files: #23960