#29267 closed enhancement (fixed)
wp_video_shortcode should support vimeo
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.2 | Priority: | normal |
Severity: | normal | Version: | 3.9.2 |
Component: | Media | Keywords: | has-patch |
Focuses: | Cc: |
Description ¶
The latest mediaelementjs (v2.5.1) supports vimeo videos, so wp_video_shortcode should be able to handle this. Currently wp_video_shortcode only looks for youtube videos by checking the URL through regex.
This is a must-add to 4.0!
Commits (3)
- [31016] Support chromeless Vimeo via MEjs:… by @wonderboymusic 7 years ago
- [31487] Restore the changes I made in [31016] for chromeless Vimeo that were missed in [31373].… by @wonderboymusic 7 years ago
- [31625] When editing/viewing the details of a
[video]
shortcode that has Vimeo as its source, andFroogaloop
has not already been lazy-loaded, check the details of the state's model for the videosrc
, instead of the HTML element.… by @wonderboymusic 7 years ago
Pull Requests
- Loading…
Change History (16)
#2
@ Lead Developer
7 years ago
It is too late for enhancements to 4.0. Perhaps 4.1 with a patch, though.
#3
@
7 years ago
Actually one line of regex matching should do the job :)
/wp-includes/media.php, line 1718
if ( ! preg_match( $yt_pattern, $src ) || ! preg_match( $vimeo_pattern, $src ) ) {
Well if not I can wait until 4.1.
Thank you!
#4
@
7 years ago
- Keywords 2nd-opinion added
This is a partial patch, this patch add support to Vimeo video source in the video shortcode (wp_video_shortcode).
As you can see in the image attached the video is rendered but the video player has a black bar in the bottom ( video Controls ) http://screencast.com/t/wlML14FUY .
What is the best way to tackle this? Adding a class to the video tag? see https://core.trac.wordpress.org/browser/trunk/src/wp-includes/media.php#L1846 and add the proper css class in the css files to hide the bar?
#5
@ Emeritus Committer
7 years ago
- Keywords has-patch needs-refresh added; 2nd-opinion removed
- Milestone changed from Awaiting Review to Future Release
Vimeo in MEjs requires that Froogaloop is also loaded. When it is, it is breaking jQuery. I have an example patch: 29267.2.diff
#6
@ Emeritus Committer
7 years ago
- Keywords needs-refresh removed
- Milestone changed from Future Release to 4.2
#7
@ Emeritus Committer
7 years ago
- Owner set to wonderboymusic
- Resolution set to fixed
- Status changed from new to closed
In 31016:
#9
@
7 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
You missed to add froogaloop.min.js
. I got one from https://github.com/vimeo/player-api/blob/master/javascript/froogaloop.min.js (with first line removed) so I'm unsure if that is the same version.
#10
@ Emeritus Committer
7 years ago
Thanks @dimadin - that was an svn
miss on my part, I'll add it soon
Sorry, I meant v2.15.1 is the latest version of mejs :)