"New" in + New icon on Admin Bar is black on focus

[linuxologos]

Related to: #19404

The text is black and hidden on :focus.

[jane]

@linuxlogos: What browser/OS are you using?

[linuxologos]

I can see that with IE/Firefox/Chrome (latest versions) on Windows 7 with latest trunk. I can test on Linux too, if necessary.

19410.patch​ fixes the problem for me, but I'm not sure if it's good CSS.

[koopersmith]

Confirmed — you have to click (and hold) the "New" item on the front-end to notice the bug. It's important that we only fix this for when jQuery is disabled, as the focus styles differ.

attachment:19410.2.diff​ addresses this issue and the simplest selector in the correct place.

[nacin]

I can confirm the bug. Not completely read up on the selectors, but 19410.2.diff​ looks good.

[nacin]

Okay, I'm now read up. +1.

[linuxologos]

Replying to koopersmith:

Confirmed — you have to click (and hold) the "New" item on the front-end to notice the bug. It's important that we only fix this for when jQuery is disabled, as the focus styles differ.

Yes, I was at the front-end with TwentyEleven, where jQuery is not enabled by default.

19410.2.diff​ works fine.

[ryan]

Looks good.

[nacin]

In [19540]:

Admin bar styling: Ensure text next to icon stays visible on focus when jQuery is not loaded. props koopersmith, linuxologos, fixes #19410.