WordPress.org

Making WordPress.org

Opened 15 months ago

Closed 15 months ago

Last modified 15 months ago

#5307 closed defect (fixed)

Theme Directory RTL arrows issues

Reported by: ramiy Owned by: dd32
Milestone: Priority: normal
Component: Theme Directory Keywords: needs-patch has-screenshots
Cc:

Description

The arrows in the Hebrew Theme Directory (​https://he.wordpress.org/themes/) are pointing to the wrong direction.

See the attached screenshots.

Attachments (4)

single-theme-view-en.png​ (402.1 KB) - added by ramiy 15 months ago.
single-theme-view-he.png​ (373.7 KB) - added by ramiy 15 months ago.
5307.patch​ (710 bytes) - added by ramiy 15 months ago.
5307.2.patch​ (708 bytes) - added by ramiy 15 months ago.

Download all attachments as: .zip

Change History (12)

@ramiy
15 months ago

@ramiy
15 months ago

#1 @ramiy
15 months ago

  • Keywords needs-patch has-screenshots added

#2 @ramiy
15 months ago

You should also check the See all Ratings arrow, the following CSS:

[dir=ltr] .theme-ratings .reviews-link:after
[dir=rtl] .theme-ratings .reviews-link:before
  • LTR CSS uses :after with float:right
  • RTL CSS uses :before with float:left

They should both use :after as the icon displayed after the text in both cases - this way you can delete the float.

#3 @dd32
15 months ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 10032:

Theme Directory: RTL: Flip the unicode arrows.

Props ramiy.
Fixes #5307.

#4 follow-up: @dd32
15 months ago

@ramiy I didn't alter the CSS setup as I didn't want to potentially break something.. so I just flipped the characters.

Can you confirm that these are now in the correct directions?

#5 in reply to: ↑ 4 @ramiy
15 months ago

Replying to dd32:

@ramiy I didn't alter the CSS setup as I didn't want to potentially break something.. so I just flipped the characters.

It wont break.

Can you confirm that these are now in the correct directions?

Yes. I confirm. Its was fixed.

@ramiy
15 months ago

#6 @ramiy
15 months ago

@dd32 Please review the attached patch.

#7 @dd32
15 months ago

In 10034:

Theme Directory: Simplify RTL reviews-link CSS.

Props ramiy.
Fixes #5307.

@ramiy
15 months ago

#8 @ramiy
15 months ago

Sorry, the last patch is irrelevant...

And thanks you for fixing this.

Note: See TracTickets for help on using tickets.