Skip to content

/ gutenberg Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaces usages of workspaceRoot with workspaceFolder. #34887

Merged
merged 1 commit into from Sep 17, 2021
Merged

Replaces usages of workspaceRoot with workspaceFolder. #34887

merged 1 commit into from Sep 17, 2021

Conversation

@jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Sep 16, 2021

Follow up on #34269.

Replace remaining usages of workspaceRoot with workspaceFolder because workspaceRoot was deprecated as a vscode variable https://code.visualstudio.com/docs/editor/variables-reference#_why-isnt-workspaceroot-documented.
@jorgefilipecosta
Replaces usages of workspaceRoot with workspaceFolder.
cc912c8
noahtallen
noahtallen approved these changes Sep 16, 2021
View changes
Copy link
Member

@noahtallen noahtallen left a comment

Makes sense to me

@gziolo gziolo merged commit 1059d10 into trunk Sep 17, 2021
20 checks passed
@gziolo gziolo deleted the update/replace-workspaceRoot-with-workspaceFolder branch Sep 17, 2021
@github-actions github-actions bot added this to the Gutenberg 11.6 milestone Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahtallen noahtallen

@ajitbohra ajitbohra

@nerrad nerrad

@ntwb ntwb

Assignees
No one assigned
Labels
[Type] Build Tooling
Projects
None yet
Milestone
Gutenberg 11.6
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jorgefilipecosta @noahtallen @gziolo