Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the new color picker design #34598

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

@jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Sep 6, 2021

Part of #34284.
Applies the design changes specified by @ciampo in order to try to match what was proposed in the mockups:

  • Adjust the white border on the circle controls to match design (compare storybook with design mockup).
  • The input padding is off, not sure if this is something we need to affect on all inputs or we can just start with the input + slider case.
  • Spacing between slider and input is off.
  • Use the new settings icon from wp/icons.
  • the color format dropdown should be rendered without borders (not sure how we want to handle this at the component level since it should be an optional thing used rarely)
  • Adjust circular handle of slider since it's too big compared to designs

Description

Screenshots

Before:
color-picker-before

After:
color-picker-after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant