Incorrect comment ordering when comment threading is turned off

[jmdodd]

comments_template() performs all comment queries with $comment_args['hierarchical'] = 'threaded' rather than checking the site option for thread_comments. When comment display is no longer threaded, the comments appear in flattened hierarchical order rather than chronologically. This is a regression from 4.3.2, where turning off threading resulted in comments ordered chronologically.

A conditional check also needs to be added prior to getting each comment's children. This operation is only needed when the array of $_comments contains only top-level comments.

[boonebgorges]

@jmdodd Thanks for the ticket and the patch!

[boonebgorges]

In 36226:

In comments_template(), don't run hierarchical queries if comment threading is disabled.

When hierarchical=true, WP_Comment_Query will always fetch comments according
to the comment hierarchy, even if 'thread_comments' is disabled for the site.
This can cause problems when comment threading is disabled after threaded
comments have been recorded on the site; comments will no longer be returned in
a strictly chronological order.

We address the issue by refraining from querying hierarchically when comment
threading is disabled.

Props jmdodd.
Fixes #35378.

[boonebgorges]

Reopening for 4.4.2 consideration.

[dd32]

In 36353:

Comments: In comments_template(), don't run hierarchical queries if comment threading is disabled.

When hierarchical=true, WP_Comment_Query will always fetch comments according to the comment hierarchy, even if 'thread_comments' is disabled for the site.
This can cause problems when comment threading is disabled after threaded comments have been recorded on the site; comments will no longer be returned in a strictly chronological order.
We address the issue by refraining from querying hierarchically when comment threading is disabled.

Merges [36226] to the 4.4 branch.
Props jmdodd.
Fixes #35378.