The Wayback Machine - https://web.archive.org/web/20210927234539/https://core.trac.wordpress.org/ticket/37882

WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 2 years ago

#37882 new defect (bug)

Typo in the tests/qunit/wp-admin/js/customize-header.js

Reported by: tymvie Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.9
Component: Customize Keywords: has-patch dev-feedback
Focuses: Cc:

Description

Fix test header in the 'Custom Header: HeaderImage shouldBeCropped()' module

Attachments (2)

37882.diff​ (588 bytes) - added by tymvie 5 years ago.
37882.2.diff​ (906 bytes) - added by tymvie 5 years ago.

Download all attachments as: .zip

Pull Requests (0)

  • To link a Pull Request to this ticket, create a new Pull Request in the WordPress GitHub mirror and include this ticket’s URL in the description.

Change History (7)

@tymvie
5 years ago

#1 follow-up: @westonruter Core Committer
5 years ago

  • Keywords reporter-feedback added

@tymvie thanks for the patch. Are you sure it is just the width or should it be width and height?

I see in the module it has:

				themeWidth: 1000,
				themeHeight: 200

And this test specifically has:

			imageWidth: 2000,
			imageHeight: 400

So note that the width and height are larger than their respective theme dimensions.

#2 in reply to: ↑ 1 @tymvie
5 years ago

@westonruter we only need the imageWidth to be greater than the themeWidth. Please see the new path

@tymvie
5 years ago

#3 @tymvie
5 years ago

  • Keywords reporter-feedback removed

#4 @westonruter Core Committer
5 years ago

I'm afraid that I'm not familiar enough with the tests here to judge whether or not the changes are correct.

@ericlewis are you more familiar with these?

#5 @desrosj Core Committer
2 years ago

  • Keywords has-patch dev-feedback added
  • Milestone changed from Awaiting Review to Future Release
Note: See TracTickets for help on using tickets.