Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-env: Ensure the environment is used with the logs command. #27907

Open
wants to merge 1 commit into
base: master
from

Conversation

@pablinos
Copy link
Contributor

@pablinos pablinos commented Dec 28, 2020

Description

While I was debugging something I noticed I was working with the test
environment rather than the main development one. I realised I couldn't
switch to tailing the logs of the test environment, and it was because
the optional parameter wasn't being passed to the command.

This change fixes that, by adding the optional parameter to the command
definition.

How has this been tested?

Using the command: npm run wp-env logs tests

Without this change the main wordpress environment logs are still shown, but with it, you can see the logs for the tests environment.

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
While I was debugging something I noticed I was working with the test
environment rather than the main development one. I realised I couldn't
switch to tailing the logs of the test environment, and it was because
the optional parameter wasn't being passed to the command.

This change fixes that, by adding the optional parameter to the command
definition.
@pablinos pablinos requested a review from noahtallen as a code owner Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.