Add a useConstrainedTabbing hook #27544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] New API
youknowriad
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +20.6 kB (1%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Dec 7, 2020
ntsekouras
reviewed
Dec 7, 2020
ntsekouras
reviewed
Dec 7, 2020
ellatrix
reviewed
Dec 7, 2020
|
@youknowriad I have a PR for |
ellatrix
approved these changes
Dec 7, 2020
|
Looks like the mobile tests are failing here. cc @ceyhun |
|
Didn't see any issues in the android screen recordings and iOS is passing. Will restart the android one. |
|
In the last commit, I'm exposing an empty useConstrainedTabbing hook for mobile. I hope it fixes the issue. |
This was referenced Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #27502
This refactors the existing withConstrainedTabbing HoC as a React hook to avoid the extra wrapper.
This is the first of three or four a11y HoCs I'd like to refactor. The goal here is to be able to remove the PopoverWrapper component that is duplicated across three packages and reuse a single hook.