Skip to content

/ extension-command

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show a warning when theme delete --all skips the active theme #218

Merged
merged 1 commit into from Mar 12, 2020
Merged

Don't show a warning when theme delete --all skips the active theme #218

merged 1 commit into from Mar 12, 2020

Conversation

@emersonveenstra
Copy link
Contributor

@emersonveenstra emersonveenstra commented Mar 11, 2020

Fixes issue #217

I'm not sure if only testing on the "Success: Deleted" string is good enough, but i didn't want to assume there will always be 5 themes.
@emersonveenstra
wp theme delete --all no longer errors on active theme deletion
4e19353 
Fixes issue #217
@emersonveenstra emersonveenstra requested a review from wp-cli/committers as a code owner Mar 11, 2020
@schlessera
schlessera approved these changes Mar 12, 2020
View changes
@schlessera schlessera added this to the 2.0.9 milestone Mar 12, 2020
@schlessera schlessera merged commit b24df4a into wp-cli:master Mar 12, 2020
2 checks passed
2 checks passed
@dep
DEP All dependencies are resolved
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera schlessera changed the title wp theme delete --all no longer errors on active theme deletion Don't show a warning when theme delete --all skips the active theme Mar 12, 2020
@schlessera
Copy link
Member

@schlessera schlessera commented Mar 12, 2020

Thanks for the PR, @emersonveenstra !
@emersonveenstra emersonveenstra mentioned this pull request Mar 12, 2020
Closed
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera

Assignees
No one assigned
Labels
bug command:theme-delete
Milestone
2.0.9
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@emersonveenstra @schlessera