RichText: Don't update live DOM on composition #11908
Conversation
Approving because it seems to fix the issue https://wordpress.slack.com/archives/C02QB2JS7/p1542286893546800
@iseulde Tested this branch. But another problem. |
@torounit Thanks, I'll investigate further! |
Tested this by installing Japanese on my mac and setting it up like described here. If not using qwerty, make sure to also change the Test:
|
One character should be deleted, but all characters are deleted. |
From the code change, I don't think the deletion bug is an issue with the current PR |
@torounit It would be good to have the sequence of events, e.g. using the tool shared by @ocean90: https://input-inspector.now.sh/. |
on Firefox, the deletion problem not happen. |
@torounit To be sure, this is on Mojave and Chrome? Do you use the native IME or something else? |
@iseulde Chrome: https://input-inspector.now.sh/profiles/JlVBqRhcZWtZxWvLeKFc This is on Mojave and Chrome 70. This problem occur native IME(Hiragana)and Other IME (ATOK). |
If that doesn't work I'll try 2 more things. :) |
FYI. Environment |
Thanks! @torounit @atachibana Could you test again with 9110d08? :) |
@torounit Thanks! Let me try one more thing. :) Also, why is "Enter" pressed in Chrome but not in Firefox? |
@iseulde safari: https://input-inspector.now.sh/profiles/2DDzBa29IEDb7IxmszZ9 |
@iseulde it works. in Chrome 70 on Mojave. |
@torounit Oh, great!! |
Awesome collaboration work on this PR |
@iseulde Thanks ! |
Cool! Thanks for all the help! |
Finally catching up (got caught up with messed up local env on my home MBA...)
4e060d1 - as @torounit mentioned, it seem to have fixed it!
For your info, I did test with 9110d08 and it was like this (I had not done through testing on 4.2, so I cannot be sure if worked correctly before, except for paragraph, list and quote).
I think through testing with different blocks might still be needed, but looks good! |
@waviaei Thanks for the additional testing. It seems the major issues have been fixed. Could you report any remaining issues separately? Thanks! |
Nice fix! |
* RichText: Don't trigger a change on composition * Use nativeEvent * Comment on IME * Handle onCompositionEnd
* RichText: Don't trigger a change on composition * Use nativeEvent * Comment on IME * Handle onCompositionEnd
ellatrix commentedNov 15, 2018
•
edited
Description
See #11813 and #11795. This is just an attempt at fixing the issue.
How has this been tested?
Screenshots
Types of changes
Checklist:
The text was updated successfully, but these errors were encountered: