Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usages of withState from edit-post and editor #32349

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Remove usages of withState from edit-post and editor #32349

wants to merge 1 commit into from
+38 −56

Conversation

@jsnajdr
Copy link
Contributor

@jsnajdr jsnajdr commented May 31, 2021 •
edited

Removes usages of the withState HOC from three places that still use it. It's very easy to replace the HOC with the useState hook. Kind of demonstrates how antiquated withState is today.

After this patch, withState is used only in README.md examples and in Storybook stories. No production code.
@jsnajdr
Remove usages of withState from edit-post and editor
a377596
@jsnajdr jsnajdr requested a review from sarayourfriend May 31, 2021
@jsnajdr jsnajdr self-assigned this May 31, 2021
@jsnajdr jsnajdr mentioned this pull request May 31, 2021
Draft
5 of 5 tasks complete
@Mamaduka
Copy link
Contributor

@Mamaduka Mamaduka commented May 31, 2021

I also noticed that a lot of examples in docs use withState. Do you think it would be better to start slowly updating those as well?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarayourfriend sarayourfriend

At least 1 approving review is required to merge this pull request.

Assignees

@jsnajdr jsnajdr

Labels
[Type] Code Quality
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jsnajdr @Mamaduka