WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 5 months ago

#51569 closed defect (bug) (invalid)

Fix for current_parsed_blocks value when block has inner blocks

Reported by: mkaz Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Editor Keywords:
Focuses: Cc:

Description

In https://github.com/WordPress/gutenberg/pull/26192 we refactored the block supports mechanism. It works by holding a global $current_parsed_blocks reference that it uses to determine the attributes that it needs to add to blocks.

However, when a block has inner blocks, that reference isn't updated so inner blocks end up inheriting the parent's properties (style and classes).

Related Gutenberg ticket: https://github.com/WordPress/gutenberg/pull/26291

Attachments (1)

51569.diff (1.0 KB) - added by mkaz 6 months ago.

Download all attachments as: .zip

Change History (4)

@mkaz
6 months ago

#1 @nosolosw
6 months ago

This is being ported as part of https://github.com/WordPress/wordpress-develop/pull/626. Should we perhaps let that PR take care of the updating and close this patch?

#2 @mkaz
6 months ago

  • Resolution set to invalid
  • Status changed from new to closed

Closing per @nosolosw comment above that it will get ported as part of WP/Gutenberg release.

#3 @desrosj
5 months ago

  • Component changed from General to Editor
  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.