Theme uploader: add step to confirm license before upload

[karmatosed]

We've talked about this before here: ​https://make.wordpress.org/themes/2015/06/09/gpl-and-licence-agreement/.

What could stop people just uploading would be to add a confirmation checkbox to the process. They would have to click and agree before they upload.

[Otto42]

Duplicate of #1513.

[Otto42]

Let's consolidate these tickets into a single idea.

[poena]

I am reopening this ticket as part of the work to update the review process.
A GPL check or confirmation is needed to be able to add a theme to the theme directory without manual review.

[dd32]

How about the above UI? It's just a quick set of <input type="checkbox" required="required">. We can add some logic to ensure that they're all checked upon upload too.

The notice shown there is simply the Chrome UI when a required form element isn't checked.

[poena]

Looks good to me.
I think the first permission check can help those who upload theme copies by mistake. Maybe.

[dd32]

Replying to poena:

I think the first permission check can help those who upload theme copies by mistake. Maybe.

That was my hope in the way I worded it, to give a little hint that if that's not your intention.. you're probably in the wrong place.. and that hey, don't upload a premium theme!

The other wording I can think of was something like I am the author of this theme, and wish to upload it to WordPress.org for others to use and share., a little more explicit in actions, and less "permission" but rather more "I am author".

[kafleg]

Looks good to me as well.

[dd32]

In 11271:

Theme Directory: Add a set of checkboxes authors must agree to before uploads can be processed.

This ensures that authors are aware of the requirements prior to the upload being processed (and we can now assume they are aware of it).

The result of these checkboxes are not stored anywhere, but the upload cannot proceed unless they're checked, so all uploads after now will have agreed with them.

Fixes #1514.

[kafleg]

Thank you @dd32