Add Compound Components section to components CONTRIBUTING.md #34697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
added
[Type] Developer Documentation
6 tasks
gziolo
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
It's interesting to see how those recommendations evolve.
I think I saw this egghead.io course a long time ago:
https://egghead.io/courses/react-class-component-patterns
If I remember correctly it looked back then more like Don't examples 😄
diegohaz
deleted the
update/components-contributing-compound-components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #33960 and part of #34691. This adds a new Compound components section to the CONTRIBUTING.md file in the
@wordpress/componentspackage folder.View rendered